Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated abiotic module summary #120

Merged
merged 4 commits into from
Nov 23, 2022
Merged

updated abiotic module summary #120

merged 4 commits into from
Nov 23, 2022

Conversation

vgro
Copy link
Collaborator

@vgro vgro commented Nov 23, 2022

Description

Updated documentation general overview over abiotic module (was very outdated).

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • [] Tests added that prove fix is effective or that feature works

@vgro vgro requested a review from jacobcook1995 November 23, 2022 13:08
Copy link
Collaborator

@jacobcook1995 jacobcook1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me! Just a few minor changes needed

docs/source/virtual_rainforest/module_overview.md Outdated Show resolved Hide resolved
docs/source/virtual_rainforest/module_overview.md Outdated Show resolved Hide resolved
docs/source/virtual_rainforest/module_overview.md Outdated Show resolved Hide resolved
docs/source/virtual_rainforest/module_overview.md Outdated Show resolved Hide resolved
docs/source/virtual_rainforest/module_overview.md Outdated Show resolved Hide resolved
docs/source/virtual_rainforest/module_overview.md Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2022

Codecov Report

Merging #120 (af79778) into develop (290caba) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #120   +/-   ##
========================================
  Coverage    96.35%   96.35%           
========================================
  Files           10       10           
  Lines          412      412           
========================================
  Hits           397      397           
  Misses          15       15           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vgro vgro requested a review from jacobcook1995 November 23, 2022 16:40
1. the understorey where most large animal are active, and
1. the near surface which homes ground-dwelling organisms and links the atmosphere to
the top soil layer.
2. the upper canopy where most photosynthetic activity occurs (~20 m to top of canopy,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW you can get away with using 1. 1. 1. 1. for a numbered list, I think it's actually the preferred style as it's numbered automatically rather than relying on always getting the order of the numbers in the list right. Minor thing though and no need to change

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is good to know. It changed it automatically last time and I thought I had made a mistake and changed it back. I'll remember for the future

@vgro vgro merged commit 1f42462 into develop Nov 23, 2022
@vgro vgro deleted the feature/abiotic_doc branch November 23, 2022 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants