Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI]: fix docs generation #359

Merged
merged 16 commits into from
Feb 27, 2025
Merged

[CI]: fix docs generation #359

merged 16 commits into from
Feb 27, 2025

Conversation

pitmonticone
Copy link
Collaborator

No description provided.

@pitmonticone pitmonticone changed the title [CI]: test doc-gen fix [CI]: try doc-gen fix Feb 27, 2025
@pitmonticone pitmonticone changed the title [CI]: try doc-gen fix [CI]: fix docs Feb 27, 2025
@pitmonticone pitmonticone changed the title [CI]: fix docs [CI]: fix docs generation Feb 27, 2025
@pitmonticone pitmonticone marked this pull request as ready for review February 27, 2025 07:21
~/.elan/bin/lake exe cache get

# Disable an error message due to a non-blocking bug. See Zulip
MATHLIB_NO_CACHE_ON_UPDATE=1 ~/.elan/bin/lake update FLT
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just echoing Ruben's comment on Zulip -- is there a reason we're not getting cache any more?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, because it's unnecessary since lake update already does that.

# Clean up after ourselves
rm -rf docbuild
sudo chown -R runner docs
cp -r docbuild/.lake/build/doc docs/docs
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we are no longer cleaning up after ourselves?

Copy link
Collaborator Author

@pitmonticone pitmonticone Feb 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We save docbuild/.lake/build/doc to cache so we need it and we don't want to remove it.

@kbuzzard kbuzzard merged commit 0a4001b into main Feb 27, 2025
2 checks passed
@kbuzzard kbuzzard deleted the pitmonticone/test-doc-fix branch February 27, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants