Skip to content

Commit

Permalink
Merge pull request #66 from ImaginativeShohag/dev
Browse files Browse the repository at this point in the history
fix: build actions
  • Loading branch information
ImaginativeShohag authored Dec 30, 2024
2 parents 29eec40 + 2f245a1 commit dca0fe1
Show file tree
Hide file tree
Showing 47 changed files with 700 additions and 669 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/build-beta-upload-android.yml
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,9 @@ jobs:
run: ./gradlew :app:generateBaselineProfile
-Pandroid.testoptions.manageddevices.emulator.gpu="swiftshader_indirect"
-Pandroid.experimental.testOptions.managedDevices.emulator.showKernelLogging=true
# -Pandroid.experimental.androidTest.numManagedDeviceShards=1
# -Pandroid.experimental.testOptions.managedDevices.maxConcurrentDevices=1
# -Pandroid.experimental.testOptions.managedDevices.setupTimeoutMinutes=5
-Pandroid.experimental.androidTest.numManagedDeviceShards=1
-Pandroid.experimental.testOptions.managedDevices.maxConcurrentDevices=1
--stacktrace

- name: Build & deploy Android release
run: bundle exec fastlane android beta
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/build-production-upload-android.yml
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,9 @@ jobs:
run: ./gradlew :app:generateBaselineProfile
-Pandroid.testoptions.manageddevices.emulator.gpu="swiftshader_indirect"
-Pandroid.experimental.testOptions.managedDevices.emulator.showKernelLogging=true
# -Pandroid.experimental.androidTest.numManagedDeviceShards=1
# -Pandroid.experimental.testOptions.managedDevices.maxConcurrentDevices=1
# -Pandroid.experimental.testOptions.managedDevices.setupTimeoutMinutes=5
-Pandroid.experimental.androidTest.numManagedDeviceShards=1
-Pandroid.experimental.testOptions.managedDevices.maxConcurrentDevices=1
--stacktrace

- name: Build & deploy Android release
run: bundle exec fastlane android deploy
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ktlint_with_reviewdog.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,5 @@ jobs:
with:
github_token: ${{ secrets.github_token }}
reporter: github-pr-review
ktlint_version: 1.3.1
custom_rule_path: spotless/ktlint/ktlint-compose-0.4.5-all.jar
ktlint_version: 1.4.1
custom_rule_path: spotless/ktlint/ktlint-compose-0.4.22-all.jar
4 changes: 2 additions & 2 deletions .idea/ktlint-plugin.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

30 changes: 15 additions & 15 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
# Why Not Compose!

A collection of animations, compositions, UIs using Jetpack Compose. You can say Jetpack Compose
cookbook or play-ground if you want!
A collection of animations, compositions, and UIs using Jetpack Compose. You can say Jetpack Compose
cookbook or playground if you want!

Feel free to request features or suggestions for improvements.
Please feel free to ask for features or suggestions for improvements.

[![Developer](https://img.shields.io/badge/Maintainer-ImaginativeShohag-green)](https://github.com/ImaginativeShohag)
[![Buy Me A Coffee](https://img.shields.io/badge/-buy_me_a_coffee-gray?logo=buy-me-a-coffee)](https://www.buymeacoffee.com/ImShohag)
Expand Down Expand Up @@ -34,9 +34,9 @@ Feel free to request features or suggestions for improvements.

### Animations

| <img src="images/animated-text-and-bubbles.gif" style="width:320px"> | <img src="images/the-story.gif" style="width:320px"> | <img src="images/running-car.gif" style="width:320px"> |
|:--------------------------------------------------------------------:|:----------------------------------------------------:|:------------------------------------------------------:|
| <img src="images/emudi.gif" style="width:320px"> | | |
| <img src="images/animated-text-and-bubbles.gif" style="width:320px"/> | <img src="images/the-story.gif" style="width:320px"/> | <img src="images/running-car.gif" style="width:320px"/> |
|:---------------------------------------------------------------------:|:-----------------------------------------------------:|:-------------------------------------------------------:|
| <img src="images/emudi.gif" style="width:320px"> | | |

### Compositions

Expand All @@ -50,9 +50,9 @@ Feel free to request features or suggestions for improvements.

### UIs

| ![Map View](images/map-view.png) | ![OTP code verify](images/otp-code-verify.png) | ![Web View](images/web-view.png) |
|:--------------------------------:|:----------------------------------------------:|:--------------------------------:|
| ![Pager](images/pager.mp4) | | |
| <img src="images/map-view.png" alt="Map View" style="width:320px"/> | <img src="images/otp-code-verify.png" alt="OTP code verify" style="width:320px"/> | <img src="images/web-view.png" alt="Web View" style="width:320px"/> |
|:-----------------------------------------------------------------------------------------------------:|:---------------------------------------------------------------------------------:|:-------------------------------------------------------------------:|
| <video src="https://github.com/user-attachments/assets/263d712f-1d9a-4e2e-bbf2-e006ab42591a"></video> | | |

### Tutorials

Expand All @@ -75,10 +75,10 @@ Feel free to request features or suggestions for improvements.
- Baseline Profiles (Intermediate)
- [Barcode Scanner](https://developers.google.com/ml-kit/vision/barcode-scanning) ([Google code scanner](https://developers.google.com/ml-kit/vision/barcode-scanning/code-scanner) and [ML Kit Barcode](https://developers.google.com/ml-kit/vision/barcode-scanning/android)) (Intermediate)

| ![Counter](images/counter.gif) | ![Animated Visibility](images/animated-visibility.gif) | ![Lottie](images/lottie.gif) |
|:------------------------------------:|:------------------------------------------------------:|:----------------------------:|
| ![Exo Player](images/exo-player.gif) | ![Tic-Tac-Toe](images/tic-tac-toe.gif) | ![CMS](images/cms.gif) |
| ![Deep Links](images/deep-links.gif) | ![Barcode Scanner](images/barcode_scanner.mp4) | |
| <img src="images/counter.gif" alt="Counter" style="width:320px"/> | <img src="images/animated-visibility.gif" alt="Animated Visibility" style="width:320px"/> | <img src="images/lottie.gif" alt="Lottie" style="width:320px"/> |
|:-----------------------------------------------------------------------:|:-------------------------------------------------------------------------------------------------------------------------:|:---------------------------------------------------------------:|
| <img src="images/exo-player.gif" alt="Exo Player" style="width:320px"/> | <img src="images/tic-tac-toe.gif" alt="Tic-Tac-Toe" style="width:320px"/> | <img src="images/cms.gif" alt="CMS" style="width:320px"/> |
| <img src="images/deep-links.gif" alt="Deep Links" style="width:320px"/> | <video src="https://github.com/user-attachments/assets/71d86d8e-1b4e-4a0d-bf2c-e9bb84bb5d39" style="width:320px"></video> | |

# TODO

Expand Down Expand Up @@ -113,7 +113,7 @@ Feel free to request features or suggestions for improvements.

- For dependency version check I am currently
using [Gradle Versions Plugin](https://github.com/ben-manes/gradle-versions-plugin#using-a-gradle-init-script)
. I added this in the Gradle init script and can check versions using the following commend.
. I added this in the Gradle init script and can check versions using the following command.

```bash
./gradlew dependencyUpdates
Expand Down Expand Up @@ -180,4 +180,4 @@ distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
```
```
2 changes: 1 addition & 1 deletion app/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ android {
minSdk = BuildConfigConst.minSdk
targetSdk = BuildConfigConst.targetSdk
versionCode = (findProperty("android.injected.version.code") as? String)?.toIntOrNull() ?: 1
versionName = "7.2.1.${getCurrentDateAsYYMMDD()}" // Major.Minor.Patch.YYMMDD
versionName = "7.2.2.${getCurrentDateAsYYMMDD()}" // Major.Minor.Patch.YYMMDD
vectorDrawables.useSupportLibrary = true

testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -218,8 +218,7 @@ sealed class UIsScreen(val route: String) {
data object UiMapView : UIsScreen("ui/mapview")
data object UiMapViewDetails : UIsScreen("ui/mapview/details?item={item}") {
const val PARAM_ITEM = "item"
fun createRoute(item: MapPlace) =
route.replace("{$PARAM_ITEM}", item.getJsonFromObj() ?: "")
fun createRoute(item: MapPlace) = route.replace("{$PARAM_ITEM}", item.getJsonFromObj() ?: "")
}

data object UiOtpCodeVerify : UIsScreen("ui/otpcodeverify")
Expand Down Expand Up @@ -253,8 +252,7 @@ sealed class TutorialsScreen(val route: String) {
data object TutorialNavDataPassScreen1 :
TutorialsScreen("tutorial/nav-data-pass/one/{data}") {
const val PARAM_DATA = "data"
fun createRoute(item: DemoData) =
route.replace("{$PARAM_DATA}", item.getJsonFromObj() ?: "")
fun createRoute(item: DemoData) = route.replace("{$PARAM_DATA}", item.getJsonFromObj() ?: "")
}

data object TutorialNavDataPassScreen2 : TutorialsScreen("tutorial/nav-data-pass/two") {
Expand All @@ -266,10 +264,9 @@ sealed class TutorialsScreen(val route: String) {
const val PARAM_ID = "id"
const val PARAM_NAME = "name"

fun createRoute(id: Int, name: String) =
route
.replace("{$PARAM_ID}", "$id")
.replace("{$PARAM_NAME}", name)
fun createRoute(id: Int, name: String) = route
.replace("{$PARAM_ID}", "$id")
.replace("{$PARAM_NAME}", name)
}

data object TutorialNavDataPassScreen4 :
Expand All @@ -280,9 +277,8 @@ sealed class TutorialsScreen(val route: String) {
const val ARG_NAME = "name"
const val ARG_RANKS = "ranks"

fun createRoute(id: Int) =
route
.replace("{$PARAM_ID}", "$id")
fun createRoute(id: Int) = route
.replace("{$PARAM_ID}", "$id")
}

data object TutorialNavDataPassScreen5 :
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,8 @@ fun ComposeOneScreen() {
.fillMaxSize()
) {
with(density) {
val maxWidth = maxWidth
val maxHeight = maxHeight
val maxWidth = this@BoxWithConstraints.maxWidth
val maxHeight = this@BoxWithConstraints.maxHeight

for (i in 0..50) {
var state by remember { mutableStateOf(false) }
Expand Down
Loading

0 comments on commit dca0fe1

Please sign in to comment.