-
-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ME] WebP support #261
[ME] WebP support #261
Conversation
@RikkiBalboa |
@takahiro0327 I didn't link to any external dll files. But I use the code from webp-unity3d to load them, which uses libwebp-net. |
@RikkiBalboa
|
@takahiro0327 Most people I've tested it with seem to load it just fine. But from your situation it seems that isn't any sort of guarantee. So I'll look into something so it gets included (or at least fails more gracefully) |
Please do. I was in the minority. |
It might be included in codec packs or in certain C++ redistributables. |
Co-authored-by: ManlyMarco <[email protected]>
@takahiro0327 Could you test if it now works for you? You need to put the newly included |
@RikkiBalboa If I had left it as it is, it would not work because the following two things did not match.
I changed the argument of mono_dllmap_insert to “webp” and it works.
How about putting this message in the log?
I don't know how to recover from just “failed to load libwebp”. |
@takahiro0327 Thanks! I missed that. It should now use the proper names, while still allowing easy extension for any other file formats in the future |
Reads the file signature from the bytes to determine the file format, and thus which loading method to use.
Uses code from this repo to read and convert WebP to a Texture2D