This repository was archived by the owner on Sep 5, 2023. It is now read-only.
Add jupyterhub api token to cull idle service #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Greg <[email protected]>
Signed-off-by: Greg <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #86 +/- ##
=======================================
Coverage 78.97% 78.97%
=======================================
Files 24 24
Lines 1788 1788
=======================================
Hits 1412 1412
Misses 376 376 Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing workflow requires using the jupyterhub api token to register new users and users within new and existing groups. This PR adds the jupyterhub api token as an env var to the cull idle service (even though the cull idle service itself is an internally managed service and doesn't need the api token set explicitly).