Skip to content
This repository was archived by the owner on Sep 5, 2023. It is now read-only.

Remove unused spawner hooks #627

Merged
merged 2 commits into from
Oct 29, 2021

Conversation

jgwerner
Copy link
Member

  • Removes unused spawner hooks and customized KubeSpawner to set shared grader folders for instructors

Signed-off-by: Greg Werner <[email protected]>
@jgwerner jgwerner added the refactor Move code around to keep things DRY label Oct 25, 2021
@jgwerner jgwerner requested a review from Abhi94N October 25, 2021 19:57
@jgwerner jgwerner self-assigned this Oct 25, 2021
@codecov
Copy link

codecov bot commented Oct 25, 2021

Codecov Report

Merging #627 (a5c7f94) into main (71f21e9) will increase coverage by 3.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #627      +/-   ##
==========================================
+ Coverage   66.33%   69.36%   +3.02%     
==========================================
  Files          12       10       -2     
  Lines         802      767      -35     
==========================================
  Hits          532      532              
+ Misses        270      235      -35     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71f21e9...a5c7f94. Read the comment docs.

@jgwerner jgwerner requested a review from rupeshparab October 27, 2021 14:57
Copy link
Contributor

@rupeshparab rupeshparab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jgwerner jgwerner merged commit ca58cea into IllumiDesk:main Oct 29, 2021
@jgwerner jgwerner deleted the refactor/remove-spawner-hooks branch October 29, 2021 06:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
refactor Move code around to keep things DRY
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants