Skip to content
This repository was archived by the owner on Sep 5, 2023. It is now read-only.

Remove header and footer settings from config #619

Merged
merged 1 commit into from
Aug 19, 2021

Conversation

jgwerner
Copy link
Member

Removes the header and footer templates from the standard nbgrader_config.py for shared grader notebooks.

@jgwerner jgwerner added the refactor Move code around to keep things DRY label Aug 19, 2021
@jgwerner jgwerner requested a review from Abhi94N August 19, 2021 00:59
@jgwerner jgwerner self-assigned this Aug 19, 2021
@codecov
Copy link

codecov bot commented Aug 19, 2021

Codecov Report

Merging #619 (b79b704) into main (c02cd95) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #619   +/-   ##
=======================================
  Coverage   66.33%   66.33%           
=======================================
  Files          12       12           
  Lines         802      802           
=======================================
  Hits          532      532           
  Misses        270      270           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c02cd95...b79b704. Read the comment docs.

Copy link

@Abhi94N Abhi94N left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgwerner jgwerner merged commit 8966ef2 into IllumiDesk:main Aug 19, 2021
@jgwerner jgwerner deleted the refactor/rm-header-footer branch August 19, 2021 02:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
refactor Move code around to keep things DRY
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants