Skip to content
This repository was archived by the owner on Sep 5, 2023. It is now read-only.

Remove int cast for gid/uid #604

Merged
merged 2 commits into from
Jul 26, 2021

Conversation

jgwerner
Copy link
Member

@jgwerner jgwerner commented Jul 17, 2021

Removes the int cast for the NB_GID and NB_UID environment variables in the grader service.

This was added when reviewing bug sources for the failing grader-setup-service and finally settled on merging #602, but inadvertently left this cast in place which is not necessary.

Signed-off-by: Greg Werner <[email protected]>
@jgwerner jgwerner added the refactor Move code around to keep things DRY label Jul 17, 2021
@jgwerner jgwerner requested a review from Abhi94N July 17, 2021 19:54
@jgwerner jgwerner self-assigned this Jul 17, 2021
@codecov
Copy link

codecov bot commented Jul 17, 2021

Codecov Report

Merging #604 (c155dad) into main (af3c85b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #604   +/-   ##
=======================================
  Coverage   66.50%   66.50%           
=======================================
  Files          12       12           
  Lines         806      806           
=======================================
  Hits          536      536           
  Misses        270      270           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af3c85b...c155dad. Read the comment docs.

Copy link

@Abhi94N Abhi94N left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgwerner jgwerner merged commit 8b3378d into IllumiDesk:main Jul 26, 2021
@jgwerner jgwerner deleted the refactor/remove-int-cast branch July 26, 2021 16:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
refactor Move code around to keep things DRY
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants