Skip to content
This repository was archived by the owner on Sep 5, 2023. It is now read-only.

Remove sending grades with illumidesk package #597

Merged
merged 4 commits into from
Jul 8, 2021

Conversation

jgwerner
Copy link
Member

@jgwerner jgwerner commented Jul 8, 2021

Deprecate sending grades with the src/illumidesk package. This will be replaced in the new future with a Node-based solution.

Closes #596

@jgwerner jgwerner added the refactor Move code around to keep things DRY label Jul 8, 2021
@jgwerner jgwerner requested review from rupeshparab and Abhi94N July 8, 2021 17:22
@jgwerner jgwerner self-assigned this Jul 8, 2021
Signed-off-by: Greg Werner <[email protected]>
@codecov
Copy link

codecov bot commented Jul 8, 2021

Codecov Report

Merging #597 (a2288d7) into main (56194be) will decrease coverage by 1.94%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #597      +/-   ##
==========================================
- Coverage   68.40%   66.45%   -1.95%     
==========================================
  Files          15       12       -3     
  Lines         959      805     -154     
==========================================
- Hits          656      535     -121     
+ Misses        303      270      -33     
Impacted Files Coverage Δ
...umidesk/illumidesk/authenticators/authenticator.py 73.68% <100.00%> (-0.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56194be...a2288d7. Read the comment docs.

jgwerner added 2 commits July 8, 2021 13:56
Signed-off-by: Greg Werner <[email protected]>
Signed-off-by: Greg Werner <[email protected]>
Copy link

@Abhi94N Abhi94N left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@rupeshparab rupeshparab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jgwerner jgwerner merged commit 08ecd8a into IllumiDesk:main Jul 8, 2021
@jgwerner jgwerner deleted the feat/deprecate-sending-grades branch July 8, 2021 18:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
refactor Move code around to keep things DRY
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate sending grades with illumidesk package
3 participants