-
Notifications
You must be signed in to change notification settings - Fork 13
Rollback commits when encountering an exception #582
Conversation
jgwerner
commented
May 27, 2021
- Adds the SQLAlchemy rollback() method when encountering an exception
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## main #582 +/- ##
==========================================
+ Coverage 66.54% 74.63% +8.09%
==========================================
Files 12 15 +3
Lines 807 1025 +218
==========================================
+ Hits 537 765 +228
+ Misses 270 260 -10
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
closing session after rollback LGTM
@Abhi94N here is a summary of the errors encountered with this PR so we can find the root cause.
The errors are related to permissions issues when the grader-setup-service attempts to deploy a new shared grader notebook. To view a stack trace of the error one just needs to replicate the POST request sent to the
We tested updating the |
Signed-off-by: Greg Werner <[email protected]>
…ntered an exception Signed-off-by: Greg Werner <[email protected]>
Signed-off-by: Greg Werner <[email protected]>
Signed-off-by: Greg Werner <[email protected]>
Signed-off-by: Greg Werner <[email protected]>