Skip to content
This repository was archived by the owner on Sep 5, 2023. It is now read-only.

Add try/except blocks to setup course hook #570

Merged
merged 4 commits into from
May 14, 2021

Conversation

jgwerner
Copy link
Member

Closes #569

@jgwerner jgwerner added the fix Fixes a bug label May 14, 2021
@jgwerner jgwerner requested a review from Abhi94N May 14, 2021 21:55
@jgwerner jgwerner self-assigned this May 14, 2021
@codecov
Copy link

codecov bot commented May 14, 2021

Codecov Report

Merging #570 (ba000b3) into main (907e6c5) will decrease coverage by 0.96%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #570      +/-   ##
==========================================
- Coverage   75.59%   74.63%   -0.97%     
==========================================
  Files          15       15              
  Lines        1008     1025      +17     
==========================================
+ Hits          762      765       +3     
- Misses        246      260      +14     
Impacted Files Coverage Δ
src/illumidesk/illumidesk/apis/jupyterhub_api.py 56.03% <0.00%> (-4.16%) ⬇️
...umidesk/illumidesk/authenticators/authenticator.py 87.87% <50.00%> (-2.60%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 907e6c5...ba000b3. Read the comment docs.

Copy link

@Abhi94N Abhi94N left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgwerner jgwerner merged commit 7842069 into IllumiDesk:main May 14, 2021
@jgwerner jgwerner deleted the fix/add-try-except branch May 14, 2021 23:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add try/except block to setup_course hook
2 participants