Skip to content
This repository was archived by the owner on Sep 5, 2023. It is now read-only.

Updates routes to fix error where the JupyterHub rolling update was not initiated #546

Merged
merged 5 commits into from
Apr 15, 2021
Merged

Updates routes to fix error where the JupyterHub rolling update was not initiated #546

merged 5 commits into from
Apr 15, 2021

Conversation

jgwerner
Copy link
Member

  • Changes grader-setup-service Blueprint name from routes_blueprint to grader_setup_bp
  • Updates import paths
  • Removes invalid get_context attribute

Related to #536

@jgwerner jgwerner added the fix Fixes a bug label Apr 14, 2021
@jgwerner jgwerner requested a review from Abhi94N April 14, 2021 21:03
@jgwerner jgwerner self-assigned this Apr 14, 2021
Abhi94N
Abhi94N approved these changes Apr 14, 2021
View reviewed changes
Copy link

@Abhi94N Abhi94N left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jgwerner added 3 commits April 14, 2021 17:44
@jgwerner
readd _version
f38fefa 
Signed-off-by: Greg Werner <[email protected]>
@jgwerner
add init
82c1791 
Signed-off-by: Greg Werner <[email protected]>
@jgwerner
update blueprint name and imports
cde1435 
Signed-off-by: Greg Werner <[email protected]>
@jgwerner jgwerner force-pushed the fix/rolling-update branch from 1ef7988 to cde1435 Compare April 14, 2021 21:45
@codecov
Copy link

codecov bot commented Apr 14, 2021 •
edited
Loading

Codecov Report

Merging #546 (bca30d6) into main (88e905f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #546   +/-   ##
=======================================
  Coverage   75.59%   75.59%           
=======================================
  Files          15       15           
  Lines        1008     1008           
=======================================
  Hits          762      762           
  Misses        246      246

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88e905f...bca30d6. Read the comment docs.

@jgwerner jgwerner merged commit ecf4e8c into IllumiDesk:main Apr 15, 2021
@jgwerner jgwerner deleted the fix/rolling-update branch April 15, 2021 00:09
This was referenced Apr 15, 2021
Merged
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Abhi94N Abhi94N Abhi94N approved these changes

Assignees

@jgwerner jgwerner

Labels
fix Fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jgwerner @Abhi94N