This repository was archived by the owner on Sep 5, 2023. It is now read-only.
Fetch all lineitems using the pagination #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #328 +/- ##
==========================================
- Coverage 78.82% 78.38% -0.45%
==========================================
Files 21 21
Lines 1360 1383 +23
==========================================
+ Hits 1072 1084 +12
- Misses 288 299 +11
Continue to review full report at Codecov.
|
|
@netoisc let's add tests, even if basic, before merging. |
jgwerner
suggested changes
Sep 15, 2020
… link header is considerate to make another request
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the code fetch the course lineitems the response sometimes contains a header named Link that indicate us the next url to use for fetching more items. This change fetchs them recursively.