Skip to content
This repository was archived by the owner on Sep 5, 2023. It is now read-only.

Automated assignment creation with LTI11 #265

Merged

Conversation

netoisc
Copy link
Contributor

@netoisc netoisc commented Aug 5, 2020

Expands upon #260 to create assignments with LTI 1.1.

…ith lti11 authenticator. Adjust the code to get the assignment name from the request args
@netoisc netoisc added feature New feature or request lti11 LTI 1.1 authenticator and handlers labels Aug 5, 2020
@netoisc netoisc self-assigned this Aug 5, 2020
@codecov
Copy link

codecov bot commented Aug 6, 2020

Codecov Report

Merging #265 into main will decrease coverage by 0.23%.
The diff coverage is 74.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #265      +/-   ##
==========================================
- Coverage   80.81%   80.58%   -0.24%     
==========================================
  Files          21       21              
  Lines        1298     1308      +10     
==========================================
+ Hits         1049     1054       +5     
- Misses        249      254       +5     
Impacted Files Coverage Δ
src/illumidesk/apis/nbgrader_service.py 83.01% <0.00%> (ø)
src/illumidesk/authenticators/authenticator.py 92.71% <70.00%> (-2.18%) ⬇️
src/illumidesk/authenticators/utils.py 96.29% <90.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b769be...a8a264a. Read the comment docs.

@netoisc netoisc marked this pull request as ready for review August 6, 2020 21:19
@netoisc netoisc requested a review from jgwerner August 6, 2020 22:05
Copy link
Member

@jgwerner jgwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the current scope of this PR assume that the assignment may only be created when:

  1. The assignment grade book file does not exist
  2. If the assignment grade book does exist, it has to comply with the new schema which considers the line items id column

If either of this condition are not met, the authentication flow should continue, as of now, an unhandled exception is thrown so the user sees a 500 errorcorrect?

@jgwerner jgwerner merged commit beadb21 into IllumiDesk:main Aug 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature or request lti11 LTI 1.1 authenticator and handlers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants