Skip to content
This repository was archived by the owner on Sep 5, 2023. It is now read-only.

Fix to determine what authenticator is used to submit grades #251

Merged
merged 4 commits into from
Jul 28, 2020

Conversation

netoisc
Copy link
Contributor

@netoisc netoisc commented Jul 28, 2020

When LTI 11Authenticator was used as the authentication type, the SendGradesHandler class ignores the logic to send grades through lti11

@netoisc netoisc added fix Fixes a bug lti11 LTI 1.1 authenticator and handlers labels Jul 28, 2020
@netoisc netoisc requested a review from jgwerner July 28, 2020 14:42
@codecov
Copy link

codecov bot commented Jul 28, 2020

Codecov Report

Merging #251 into main will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #251      +/-   ##
==========================================
- Coverage   80.77%   80.72%   -0.05%     
==========================================
  Files          20       20              
  Lines        1212     1209       -3     
==========================================
- Hits          979      976       -3     
  Misses        233      233              
Impacted Files Coverage Δ
src/illumidesk/grades/handlers.py 76.00% <100.00%> (-2.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4bf8b5...f97e1e2. Read the comment docs.

Copy link
Member

@jgwerner jgwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgwerner jgwerner merged commit ff952fc into IllumiDesk:main Jul 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
fix Fixes a bug lti11 LTI 1.1 authenticator and handlers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants