Minification #35
Merged
Minification #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixtures are taken from babel plugin
- cases are in fixtures - snapshots are in baselines - use jest-specific-snapshot
- add `minify` option (default `false) - start minifying - still there're issues
Igorbek
commented
Mar 5, 2019
src/__tests__/baselines/minification/minify-css-in-helpers.ts.baseline
Outdated
Show resolved
Hide resolved
| styled.div \`bla (\`; | ||
| // ignores even unescaped URLs | ||
| // \`https://test.com\` | ||
| styled.div \`https:\`; |
There was a problem hiding this comment.
not sure it is needed... waiting more feedback
| styled.div \`https:\`; | ||
| // removes multi-line comments | ||
| // \`this is a test\` | ||
| styled.div \`this is atest\`; |
Closed
- emits unnecessery spaces in some cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds experimental support of
minifyoption.The test cases were mostly taken from Babel plugin and tried to align results.
A few discrepancies I found:
',",)-- it seems css/scss works fine with it (likeurl(..)no-repeat)Implements #14