Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(radio): doesn't work with OnPush #8807

Merged
merged 4 commits into from
Jan 20, 2021
Merged

fix(radio): doesn't work with OnPush #8807

merged 4 commits into from
Jan 20, 2021

Conversation

simeonoff
Copy link
Collaborator

Closes #8794

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@simeonoff simeonoff force-pushed the simeonoff/fix-8794 branch 2 times, most recently from e243c09 to 733f72f Compare January 18, 2021 17:56
@simeonoff simeonoff requested a review from rkaraivanov January 19, 2021 05:46
rkaraivanov
rkaraivanov previously approved these changes Jan 19, 2021
View reviewed changes
@rkaraivanov rkaraivanov self-requested a review January 19, 2021 11:27
@zdrawku zdrawku added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Jan 20, 2021
@zdrawku zdrawku merged commit 2b56923 into master Jan 20, 2021
@zdrawku zdrawku deleted the simeonoff/fix-8794 branch January 20, 2021 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkaraivanov rkaraivanov rkaraivanov approved these changes

Assignees

@zdrawku zdrawku

Labels
radio-button version: 11.1.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[igx-radio-button]: does not select any values with OnPush change detection strategy
3 participants
@simeonoff @rkaraivanov @zdrawku