Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(expansion-panel): make header interaction cancelable - master #8268

Merged
merged 4 commits into from
Oct 7, 2020
Merged

fix(expansion-panel): make header interaction cancelable - master #8268

merged 4 commits into from
Oct 7, 2020

Conversation

ViktorSlavov
Copy link
Contributor

@ViktorSlavov ViktorSlavov commented Oct 4, 2020 •
edited
Loading

Closes #8190
Make onInteraction event cancelable

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@ViktorSlavov ViktorSlavov force-pushed the vslavov/expansion-panel-cancel-interaction branch 3 times, most recently from c2a7686 to d949837 Compare October 4, 2020 18:11
@ViktorSlavov ViktorSlavov changed the title fix(expansion-panel): make header interaction cancelable, #8190 fix(expansion-panel): make header interaction cancelable - master Oct 5, 2020
@ViktorSlavov ViktorSlavov force-pushed the vslavov/expansion-panel-cancel-interaction branch from f1c39ae to 05610e6 Compare October 6, 2020 08:08
@ViktorSlavov ViktorSlavov marked this pull request as ready for review October 6, 2020 08:08
@ViktorSlavov ViktorSlavov mentioned this pull request Oct 6, 2020
Closed
14 tasks
@Lipata Lipata removed their request for review October 6, 2020 11:43
@ViktorSlavov ViktorSlavov requested a review from wnvko October 6, 2020 13:09
@valadzhov valadzhov added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Oct 6, 2020
@valadzhov valadzhov added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Oct 7, 2020
@Lipata Lipata merged commit 4075879 into master Oct 7, 2020
@Lipata Lipata deleted the vslavov/expansion-panel-cancel-interaction branch October 7, 2020 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wnvko wnvko wnvko approved these changes

@damyanpetev damyanpetev Awaiting requested review from damyanpetev

@dafo dafo Awaiting requested review from dafo

Assignees

@valadzhov valadzhov

Labels
expansion-panel version: 10.2.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

onInteraction event of the igxExpansionPanelHeaderComponent is not cancelable
4 participants
@ViktorSlavov @wnvko @Lipata @valadzhov