Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update selection when remote data is used #7391

Merged
merged 2 commits into from
May 26, 2020
Merged

Update selection when remote data is used #7391

merged 2 commits into from
May 26, 2020

Conversation

nrobakova
Copy link
Contributor

@nrobakova nrobakova commented May 22, 2020 •
edited by zdrawku
Loading

Closes #7388
Closes #6755

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@nrobakova nrobakova requested review from ddincheva and zdrawku May 26, 2020 06:21
@nrobakova nrobakova marked this pull request as ready for review May 26, 2020 06:21
@ddincheva ddincheva added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels May 26, 2020
@ddincheva ddincheva assigned ddincheva and unassigned zdrawku May 26, 2020
@ddincheva ddincheva added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels May 26, 2020
@zdrawku zdrawku merged commit 7f85ddb into master May 26, 2020
@zdrawku zdrawku deleted the nrobakova/fix-issue-7388 branch May 26, 2020 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddincheva ddincheva ddincheva approved these changes

@zdrawku zdrawku Awaiting requested review from zdrawku

Assignees

@ddincheva ddincheva

Labels
grid: general keyboard-navigation version: 9.1.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
3 participants
@nrobakova @ddincheva @zdrawku