Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scrollbar): add scrollbar theme #6818

Merged
merged 13 commits into from
Mar 17, 2020
Merged

Conversation

simeonoff
Copy link
Collaborator

@simeonoff simeonoff commented Feb 25, 2020

Closes #6675

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@simeonoff simeonoff marked this pull request as ready for review February 27, 2020 09:10
@desig9stein desig9stein added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Mar 4, 2020
Copy link
Contributor

@desig9stein desig9stein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the size of the scrollbar has unexpected behavior in the igx-grid component. Increase the size from 16px to 20px and observe.

desig9stein
desig9stein previously approved these changes Mar 13, 2020
…move hardcoded scrollbar heigth in hierarchical/tree grid.
@simeonoff
Copy link
Collaborator Author

@simeonoff If I add a theme using one of the predefined mixins, for example, igx-dark-theme everything is working correctly but if I try to use the igx-theme mixin and pass a dark palette and dark schema the scrollbar remains white.

I can't reproduce.

@simeonoff simeonoff merged commit a017bac into master Mar 17, 2020
@rkaraivanov rkaraivanov deleted the simeonoff/scrollbars-theme branch July 8, 2020 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Theme igx-component scrollbars
4 participants