Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add carousel indicators template and animations #6110

Merged
merged 32 commits into from
Nov 13, 2019

Conversation

nrobakova
Copy link
Contributor

@nrobakova nrobakova commented Nov 1, 2019

Closes: #4268
Closes: #3840
Closes: #6142

In this PR:

  1. Slides are changed from array to ContentChildren of carousel
  2. When change slide input active it is selected in the carousel
  3. A template for indicators is added
  4. A new input indicatorsOrientation is added in order to change indicators position
  5. A new input maximumIndicatorsCount is added, if the slides are more than the maximumIndicatorsCount only for example '3 of 6' is displayed
  6. Add input keyBoardSupport and it it is false, the keyboard navigation is disabled
  7. Add input animationType to select animation. Available animations are none, slide and fade

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@nrobakova nrobakova marked this pull request as ready for review November 5, 2019 14:57
@nrobakova nrobakova added the ❌ status: awaiting-test PRs awaiting manual verification label Nov 5, 2019
@nrobakova nrobakova assigned zdrawku and unassigned simeonoff and nrobakova Nov 5, 2019
Copy link
Contributor

@zdrawku zdrawku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nrobakova, below you can find the proposed changes.

@HristoP96 HristoP96 added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Nov 12, 2019
@HristoP96 HristoP96 added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Nov 12, 2019
@hanastasov hanastasov added 🛠️ status: in-development Issues and PRs with active development on them and removed ✅ status: verified Applies to PRs that have passed manual verification labels Nov 12, 2019
@HristoP96 HristoP96 added ✅ status: verified Applies to PRs that have passed manual verification and removed 🛠️ status: in-development Issues and PRs with active development on them labels Nov 13, 2019
@Lipata Lipata merged commit d2cfd8c into master Nov 13, 2019
@Lipata Lipata deleted the nrobakova/carousel-addanimations branch November 13, 2019 10:29
@joneldiablo
Copy link

how can I disable the indicators bullets?

@nrobakova
Copy link
Contributor Author

nrobakova commented Dec 2, 2019

Hi @joneldiablo,
When you want to hide the indicators you can create empty template:
<ng-template igxCarouselIndicator></ng-template>

@joneldiablo
Copy link

thanks!! other question, to remove the arrows? o.O

@nrobakova
Copy link
Contributor Author

Hi @joneldiablo,
You can remove the arrows with setting the input navigation to false:
https://www.infragistics.com/products/ignite-ui-angular/docs/typescript/latest/classes/igxcarouselcomponent.html#navigation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎠 carousel version: 9.0.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
7 participants