Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(igx-grid): Preserve selection on non-primary click #5068

Merged
merged 3 commits into from
Jun 17, 2019
Merged

fix(igx-grid): Preserve selection on non-primary click #5068

merged 3 commits into from
Jun 17, 2019

Conversation

rkaraivanov
Copy link
Member

@rkaraivanov rkaraivanov commented Jun 13, 2019 •
edited
Loading

Closes #4878

Closes #

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

ChronosSF
ChronosSF previously approved these changes Jun 13, 2019
View reviewed changes
@nrobakova nrobakova added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Jun 13, 2019
@nrobakova nrobakova added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Jun 17, 2019
@kdinev kdinev merged commit d403c0f into master Jun 17, 2019
@kdinev kdinev deleted the rkaraivanov/multi-selection-fix-master branch June 17, 2019 15:54
@rkaraivanov rkaraivanov mentioned this pull request Jun 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdinev kdinev kdinev approved these changes

@ChronosSF ChronosSF ChronosSF left review comments

@dkamburov dkamburov Awaiting requested review from dkamburov

Assignees

@nrobakova nrobakova

Labels
grid: general grid: multi-cell-selection version: 8.0.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Range selection is lost on non-primary click
4 participants
@rkaraivanov @kdinev @ChronosSF @nrobakova