-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Currency and Percent type of a Column #8331
Comments
There has been no recent activity and this issue has been marked inactive. |
@StefanIvanov, could you please consider this for the upcoming sprint - we need a design for the cell edit template when it comes to editing with dataType="currency". Here is a POC that you can use, I've used our igx-input-group component with both prefix and suffix definitions. The editor will be shown upon cell edit. @damyanpetev already shared his opinion on the subject to consider using a plain input without suffixes or prefixes. Let us know what are your thoughts. |
@zdrawku I am fine with your prefix/suffix approach and think that is the way we should go. My only advice would be changing the suffix icon to text suffix and using the currency character inside of it |
This was the exact approach that we were hoping to follow, there is a |
I notice that in your sample the grid "trembles" a bit when I go in/out of edit mode, is it a sample issue? Make sure the columns don't wiggle left and right once the feature is complete :) |
Is your feature request related to a problem? Please describe.
Currently, the
igx-grid
exposes default handling for column types like number - right aligned, string - left aligned, date and boolean. This should be expanded to better defaults for other column types - datetime, Currency, and Percent.Describe the solution you'd like.
I would like to have Currency and Percent default column type handling
Describe alternatives you've considered
Use the default angular pipes as we do with the other column types like Date and Number.
Related to #5951
The text was updated successfully, but these errors were encountered: