Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Currency and Percent type of a Column #8331

Closed
zdrawku opened this issue Oct 9, 2020 · 5 comments · Fixed by #8916 or #8988
Closed

Currency and Percent type of a Column #8331

zdrawku opened this issue Oct 9, 2020 · 5 comments · Fixed by #8916 or #8988
Assignees
Labels
grid: column-types grid: general program: igniteui project management 🧰 feature-request ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@zdrawku
Copy link
Contributor

zdrawku commented Oct 9, 2020

Is your feature request related to a problem? Please describe.

Currently, the igx-grid exposes default handling for column types like number - right aligned, string - left aligned, date and boolean. This should be expanded to better defaults for other column types - datetime, Currency, and Percent.

Describe the solution you'd like.

I would like to have Currency and Percent default column type handling

Describe alternatives you've considered

Use the default angular pipes as we do with the other column types like Date and Number.

Related to #5951

@github-actions
Copy link

github-actions bot commented Dec 9, 2020

There has been no recent activity and this issue has been marked inactive.

@github-actions github-actions bot added the status: inactive Used to stale issues and pull requests label Dec 9, 2020
@radomirchev radomirchev removed the status: inactive Used to stale issues and pull requests label Dec 14, 2020
@radomirchev radomirchev added the program: igniteui project management label Jan 19, 2021
@ddincheva ddincheva self-assigned this Feb 4, 2021
@zdrawku zdrawku added 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels Feb 4, 2021
@zdrawku
Copy link
Contributor Author

zdrawku commented Feb 5, 2021

@StefanIvanov, could you please consider this for the upcoming sprint - we need a design for the cell edit template when it comes to editing with dataType="currency". Here is a POC that you can use, I've used our igx-input-group component with both prefix and suffix definitions.

The editor will be shown upon cell edit. @damyanpetev already shared his opinion on the subject to consider using a plain input without suffixes or prefixes.

Let us know what are your thoughts.

@StefanIvanov
Copy link
Contributor

@zdrawku I am fine with your prefix/suffix approach and think that is the way we should go. My only advice would be changing the suffix icon to text suffix and using the currency character inside of it

@zdrawku
Copy link
Contributor Author

zdrawku commented Feb 5, 2021

This was the exact approach that we were hoping to follow, there is a getCurrencySymbol function that retrieves the currency symbol from a given currency code. The sample is updated accordingly.

@StefanIvanov
Copy link
Contributor

I notice that in your sample the grid "trembles" a bit when I go in/out of edit mode, is it a sample issue? Make sure the columns don't wiggle left and right once the feature is complete :)

@ddincheva ddincheva added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
grid: column-types grid: general program: igniteui project management 🧰 feature-request ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
5 participants