Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto position strategy use wrong animation when flipped #8238

Closed
wnvko opened this issue Sep 29, 2020 · 0 comments · Fixed by #8337
Closed

Auto position strategy use wrong animation when flipped #8238

wnvko opened this issue Sep 29, 2020 · 0 comments · Fixed by #8337
Assignees
@IvayloG @wnvko
Labels
🧨 severity: medium overlay 🧰 feature-request version: 11.0.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@wnvko
Copy link
Contributor

wnvko commented Sep 29, 2020

Description

In IgxOverlay when using AutoPositionStrategy in case the content is flipped, e.g. initially should show in down direction, but there is not space and it shows in upper direction, the animation is not changed.

  • igniteui-angular version: 9.1.x; 10.1.x; 10.2.x
  • browser: all

Steps to reproduce

Show overlay with AutoPositionStrategy forcing the content to be flipped.

Result

Animation starts from the top of the content.

Expected result

Overlay should use the opposite animation - from bottom to top.
@Lipata Lipata mentioned this issue Oct 1, 2020
Closed
@Lipata Lipata assigned IvayloG and unassigned Lipata Oct 2, 2020
@wnvko wnvko self-assigned this Oct 9, 2020
@wnvko wnvko added 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels Oct 9, 2020
wnvko added a commit that referenced this issue Oct 9, 2020
@wnvko
fix(overlay): change animation if flipped, #8238
5a63aee
@wnvko wnvko mentioned this issue Oct 9, 2020
Merged
14 tasks
wnvko added a commit that referenced this issue Oct 9, 2020
@wnvko
fix(overlay): change animation if flipped, #8238
340fc84
@wnvko wnvko mentioned this issue Oct 9, 2020
Closed
14 tasks
wnvko added a commit that referenced this issue Oct 9, 2020
@wnvko
fix(overlay): change animation if flipped, #8238
a650e03 
# Conflicts:
#	projects/igniteui-angular/src/lib/core/utils.ts
@wnvko wnvko mentioned this issue Oct 9, 2020
Closed
14 tasks
@wnvko wnvko added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Oct 9, 2020
wnvko added a commit that referenced this issue Oct 9, 2020
@wnvko
fix(overlay): change animation if flipped, #8238
d9ee73d 
# Conflicts:
#	projects/igniteui-angular/src/lib/core/utils.ts
wnvko added a commit that referenced this issue Oct 12, 2020
@wnvko
refactor(overlay): flip animation depending on direction, #8238
96631dd
wnvko added a commit that referenced this issue Oct 12, 2020
@wnvko
refactor(overlay): flip animation depending on direction, #8238
2c6197f
wnvko added a commit that referenced this issue Oct 12, 2020
@wnvko
refactor(overlay): flip animation depending on direction, #8238
3ce54fe
wnvko added a commit that referenced this issue Oct 12, 2020
@wnvko
refactor(overlay): flip animation depending on direction, #8238
2e7dac9
wnvko added a commit that referenced this issue Oct 12, 2020
@wnvko
refactor(overlay): flip animation depending on direction, #8238
5495435
wnvko added a commit that referenced this issue Oct 12, 2020
@wnvko
refactor(overlay): flip animation depending on direction, #8238
cb54feb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IvayloG IvayloG

@wnvko wnvko

Labels
🧨 severity: medium overlay 🧰 feature-request version: 11.0.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix animations when content is flipped IgniteUI/igniteui-angular
3 participants
@Lipata @IvayloG @wnvko