Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement factory functions for creating OverlaySettings #7941

Closed
wnvko opened this issue Aug 7, 2020 · 1 comment · Fixed by #8261, #8325 or #8369
Closed

Implement factory functions for creating OverlaySettings #7941

wnvko opened this issue Aug 7, 2020 · 1 comment · Fixed by #8261, #8325 or #8369
Assignees
@PlamenaMiteva
Labels
🧨 severity: medium overlay size: M 🧰 feature-request version: 10.2.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@wnvko
Copy link
Contributor

wnvko commented Aug 7, 2020

Is your feature request related to a problem? Please describe.

Changing existing OverlaySettings or creating a new ones is not so straight forward operation. It would be nice if there is a way to create OverlaySettings instance easier.

Describe the solution you'd like

Implement factory functions which should return OverlaySettings instance.

Describe alternatives you've considered

It is possible now to create a new instance of OverlaySettings but it is not so easy.
@wnvko
Copy link
Contributor Author

wnvko commented Aug 7, 2020

Related to #7775

@Lipata Lipata added the size: M label Aug 11, 2020
@PlamenaMiteva PlamenaMiteva self-assigned this Sep 23, 2020
@PlamenaMiteva PlamenaMiteva added 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels Sep 23, 2020
@Lipata Lipata removed their assignment Oct 1, 2020
PlamenaMiteva added a commit that referenced this issue Oct 2, 2020
@PlamenaMiteva
feat(overlay): add methods for preset position settings creation #7941
e07f13f
@PlamenaMiteva PlamenaMiteva mentioned this issue Oct 2, 2020
Merged
14 tasks
PlamenaMiteva added a commit that referenced this issue Oct 2, 2020
@PlamenaMiteva
feat(overlay): add overlay sample #7941
92a96f2
PlamenaMiteva added a commit that referenced this issue Oct 6, 2020
@PlamenaMiteva
chore(overlay): addressing comments #7941
23f3631
PlamenaMiteva added a commit that referenced this issue Oct 7, 2020
@PlamenaMiteva
feat(overlay): add description to changelog and readme #7941
2830b9d
PlamenaMiteva added a commit that referenced this issue Oct 8, 2020
@PlamenaMiteva
feat(overlay): rename left/right positions #7941
f056d6c
@Lipata Lipata added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Oct 8, 2020
PlamenaMiteva added a commit that referenced this issue Oct 8, 2020
@PlamenaMiteva
chore(overlay): add @returns to method descriptions #7941
0b5eeed
PlamenaMiteva added a commit that referenced this issue Oct 9, 2020
@PlamenaMiteva
fix(overlay): fix enums & sample #7941
7a9fd49
@PlamenaMiteva PlamenaMiteva mentioned this issue Oct 9, 2020
Merged
14 tasks
PlamenaMiteva added a commit that referenced this issue Oct 9, 2020
@PlamenaMiteva
chore(overlay): remove unused imports #7941
d4b8395
PlamenaMiteva added a commit that referenced this issue Oct 14, 2020
@PlamenaMiteva
fix(overlay): add overlay enums to public api #7941
9736df7
@PlamenaMiteva PlamenaMiteva mentioned this issue Oct 14, 2020
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PlamenaMiteva PlamenaMiteva

Labels
🧨 severity: medium overlay size: M 🧰 feature-request version: 10.2.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Milestone
No milestone
3 participants
@Lipata @wnvko @PlamenaMiteva