Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

igxCombo default positioning strategy #7225

Closed
kdinev opened this issue Apr 28, 2020 · 0 comments · Fixed by #7720
Closed

igxCombo default positioning strategy #7225

kdinev opened this issue Apr 28, 2020 · 0 comments · Fixed by #7720
Assignees
@IvayloG
Labels
combo overlay 🧰 feature-request version: 10.1.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@kdinev
Copy link
Member

kdinev commented Apr 28, 2020

Is your feature request related to a problem? Please describe.

The current default positioning strategy for the igx-combo is not auto, because the combo was developed before the auto positioning strategy.

Describe the solution you'd like

The default strategy should now be made auto.

Describe alternatives you've considered

Pass auto manually to all the combos I define.

Additional context

The other drop-down-like components are auto, or in the select case, with their own strategy, while the combo is with the old default.
@Lipata Lipata self-assigned this Apr 28, 2020
@IvayloG IvayloG assigned IvayloG and unassigned Lipata Jun 30, 2020
@radomirchev radomirchev added the 🛠️ status: in-development Issues and PRs with active development on them label Jun 30, 2020
IvayloG added a commit that referenced this issue Jun 30, 2020
@IvayloG
feat(combo): Use AutoPositionStrategy #7225
836e177 
Replace ConnectedPositioningStrategy with AutoPositionStrategy as component
default.
IvayloG added a commit that referenced this issue Jun 30, 2020
@IvayloG
chore(combo): Update dev samples #7225
84e6dc0
@IvayloG IvayloG mentioned this issue Jun 30, 2020
Merged
14 tasks
@IvayloG IvayloG added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. version: 10.1.x and removed 🛠️ status: in-development Issues and PRs with active development on them version: 10.0.x 🆕 status: new labels Jun 30, 2020
@IvayloG IvayloG mentioned this issue Jul 1, 2020
Merged
16 tasks
IvayloG added a commit that referenced this issue Jul 2, 2020
@IvayloG
chore(combo): Address comments #7225
18a9999
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IvayloG IvayloG

Labels
combo overlay 🧰 feature-request version: 10.1.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set auto positioning strategy as a default one IgniteUI/igniteui-angular
4 participants
@kdinev @Lipata @IvayloG @radomirchev