Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PropertyTableSortForm: Don't use ipl`s CSRF counter measure #2937

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

nilmerg
Copy link
Member

@nilmerg nilmerg commented Dec 2, 2024

It's incompatible with gipfl`s…

fixes #2935

@nilmerg nilmerg added the bug label Dec 2, 2024
@nilmerg nilmerg requested a review from raviks789 December 2, 2024 13:53
@nilmerg nilmerg self-assigned this Dec 2, 2024
@cla-bot cla-bot bot added the cla/signed label Dec 2, 2024
@nilmerg nilmerg added this to the v1.11.3 milestone Dec 2, 2024
@MisterMountain
Copy link

Hi, just patched my Director with this in order to fix the problem in #2935
However, now its not possible for me to sort my sync rules anymore - trying to use the sort button doesnt work, but some kind of error message "Can't get element 'CSRFToken'. Element does not exist" gets raised.

I think this might be related to this?

Screen.Recording.2024-12-03.at.09.19.07.mov

@nilmerg nilmerg force-pushed the fix/invalid-csrf-upon-import-modifier-add-2935 branch from 759af7c to 50b2b2f Compare December 3, 2024 08:43
@nilmerg
Copy link
Member Author

nilmerg commented Dec 3, 2024

Should be fixed, thanks for pointing this out!

@afeefghannam89
Copy link
Member

I tested this solution. It works, thanks :)

@nilmerg nilmerg force-pushed the fix/invalid-csrf-upon-import-modifier-add-2935 branch from 50b2b2f to cdd3fea Compare December 4, 2024 12:28
@lippserd lippserd merged commit 89ebf71 into master Dec 12, 2024
22 checks passed
@lippserd lippserd deleted the fix/invalid-csrf-upon-import-modifier-add-2935 branch December 12, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid CSRF token provided : Import source modifiers form
5 participants