Fix newline terminator for bulk requests in ElasticsearchWriter #5840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables compatibility with 6.x. This commit also fixes an incorrect HTTP response parsing which could lead into false positives. Analysis and fix in #5795 (comment) fixes #5795
dnsmichi
force-pushed
the
fix/elasticsearch-writer-6
branch
from
54599d8 to
14953df
Compare
dnsmichi
pushed a commit
that referenced
this pull request
Dec 7, 2017
This enables compatibility with 6.x. This commit also fixes an incorrect HTTP response parsing which could lead into false positives. Analysis and fix in #5795 (comment) fixes #5795 refs #5840
dnsmichi
pushed a commit
that referenced
this pull request
Dec 7, 2017
|
Reverting the backport, as the problem with 6.x is not fully solved. See #5905. |
|
ES 5.6.9 doesn't need that patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables compatibility with 6.x.
This commit also fixes an incorrect HTTP response parsing
which could lead into false positives.
Analysis and fix in #5795 (comment)
fixes #5795