Fix: Prefer startup type of services fetching over WMI instead of Get-Services #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LordHepipud
force-pushed
the
fix/fetch_service_startup_type_over_wmi_instead_of_get_services
branch
from
accd287 to
37f0df1
Compare
LordHepipud
deleted the
fix/fetch_service_startup_type_over_wmi_instead_of_get_services
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, it can happen that
Get-Servicewhich is used primarily to fetch most of the service data, is not providing any results of the startup type of the service. This results in an error on the plugin, as the monitoring of all services which should be runningAutomaticand throw a critical if not exited properly is no longer possible. The result is simply "Ok" with no services checked as the status code is always 0 for all services and not matching the actual comparison value of 2 (Automatic)