Golem update #11
Merged
Golem update #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ter limitation for max possible numbers of trainable parameters (from 7e8 to 2e8).
…ing issue with keras OOM
Code update Unit tests update Unit tests update Requirements update Code refactoring WIP Model builder and LayerInitializer NasGraph refactoring; Added option to specify train parameters more flexible Dataset builder preprocessor fixes; Added unit tests for dataset builder Refactoring; Added unit test for DatasetBuilder Refactoring Refactoring BaseNasDatasetBuilder preprocessor fix; cases update BaseNasDatasetBuilder preprocessor fix Added class BaseNasDatasetBuilder for InputData preparation for model train Minor composer changes; Composer refactoring Redundant code was removed Added unit tests for requirements Default requirements hotfix Requirements update; Added unit tests for base layer requirements Requirements update golem imports update; requirements refactoring requirements update golem update history functional object remove memory hotfix Added performance callback Added unfit method Minor hotfixes Minor hotfixes Minor fixes Branch Manager fix requirements update requirements update Builder fixes Builder fixes Hotfixes for val rules: added ty except in dimension check rule Hotfixes for val rules callbacks update callbacks update setup update Added callback for model performance Minor changes Minor changes Keras optimizer changed minor changes minor changes save path fix Added temporary val rules for resnet-like networks + small fixes Refactoring; Subcalssing from Keras model was replaced with ModelConverter class. Refactoring + Updates for model generation Added graph branch manager and class for convert node to layer Added graph branch manager and class for convert node to layer Memory leak fixing Skip connections fix, minor Resnet builder fixes ResNet builder updates ResNet builder implementation for initial assumption val rule update for trainable parameters requirements update; serializer error fix Fix for trainable restrictions. Fix for trainable restrictions. Added trainable restrictions. Possible pool of conv layer types was extended; validation rules update; refactoring Pre-refactoring changes. Updating class for graph generation and solving issue with keras OOM Added layers repository Fixes for simple mutation bug Fixes for simple mutation bug Graph requirements were extended for convolutional nodes; Added stricter limitation for max possible numbers of trainable parameters (from 7e8 to 2e8).
nicl-nno
reviewed
Jan 26, 2023
nicl-nno
reviewed
Jan 26, 2023
nicl-nno
reviewed
Jan 26, 2023
nicl-nno
reviewed
Jan 26, 2023
nicl-nno
reviewed
Jan 26, 2023
nicl-nno
reviewed
Jan 26, 2023
nas/model/utils/converter.py
Outdated
| from nas.graph.node.nn_graph_node import NNNode | ||
|
|
||
|
|
||
| class GraphStruct: |
There was a problem hiding this comment.
Вот тут непонятно - это что-то keras-специфичное или нет? Хорошо бы всё что относится к keras в какой-то отдельный модуль вынести - так проще будет рефакторить. Можно в след. PR уже
There was a problem hiding this comment.
Разделил на 2 разных файла и переименовал GraphStruct. Этот класс больше вспомогательный для сбора сетки независимо от фреймворка
nicl-nno
reviewed
Jan 26, 2023
| import tensorflow | ||
|
|
||
|
|
||
| class CustomCallback(tensorflow.keras.callbacks.Callback): |
There was a problem hiding this comment.
Лучше назвать более конкретно.
There was a problem hiding this comment.
Переименовал в PerformanceChecker
There was a problem hiding this comment.
Лучше PerformanceCheckingCallback.
nicl-nno
reviewed
Jan 26, 2023
nicl-nno
approved these changes
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Core was updated for GOLEM framework