Refactor: 기수 이름 대신 숫자로 변경 (#28) #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
yunhacandy
commented
Feb 8, 2024
yunhacandy
commented
- generation_name 대신 generation_number로 수정
- 관련 예외 처리도 변경
- generation_name 대신 generation_number로 수정 - 관련 예외 처리도 변경
Youthhing
reviewed
Feb 8, 2024
src/main/java/cotato/csquiz/domain/dto/generation/GenerationInfo.java
Outdated
Show resolved
Hide resolved
- class -> record로 변경 - 서비스에 buildGenerationInfo 메서드 삭제 - record에 static 메서드 추가
Youthhing
approved these changes
Feb 8, 2024
Youthhing
changed the title
|
아 근데 pr 명은 '기수 추가 API 로직 변경' 이런식이 더 좋았을 것 같네요!! |
|
앗 그렇네요... 알려주셔서 감사합니당 |
|
하하 지금 봤는데 왜 브랜치가 generation이 아니라 education이죠..? |
|
그렇네요.... 저도 지금 인지했습니다.. 죄송합니다.. 제가 잠시 정신이 나갔던거 같아요ㅠㅠㅠㅠㅠㅠㅠㅠㅠㅠㅠㅠㅠㅠㅠㅠㅠㅠ |
Youthhing
added a commit
that referenced
this pull request
Feb 11, 2024
* feat: CI 스크립트 추가 * chore: CI 스크립트 실행권한 추가 및 이름 변경 - chmod로 ./gradlew 실행 권한 추가 - gradle -> deploy로 이름 변경 * chore: gradle 설정 코드 제거 * chore: CI 스크립트 의존성 설정 제거
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.