-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: 생명주기에 따른 JPA 연관관계 제거 #161
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `existsBySessionId` 활용
- 기수 ID 대신 합격 기수의 번호를 활용
- findAll로 모든 멤버를 조회하던 로직에서 Enum 그룹화를 통한 InQuery 사용
- passed_generation_number 로 변경
- Education의 세션 대신 sessionId 외래키 참조 설정 -> 생명 주기 제거 - in query를 통한 득점자, 정답자 조회 로직 수정
- findAllByGeneration으로 수정
- memberId를 컬럼으로 남김
- Long memberId, Long quizId로 대체
- Member -> memberId
- Long memberId를 유지
gikhoon
approved these changes
May 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
리뷰 몇개 남겼습니다
- find~ -> findAll~로 수정
- find~ -> findAll~로 수정
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 목록
불필요한 JPA의 연관관계를 제거함.
Long sessionId
를 컬럼에 남김