Signal an improvement if the internal OR the external value have impr…

…oved. It used to be that only a change of the external value could signal an improvement.
IOHprofiler · Feb 13, 2024 · 5b854df · 5b854df
1 parent 2749d33
commit 5b854df
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/include/ioh/problem/structures.hpp b/include/ioh/problem/structures.hpp
@@ -244,21 +244,23 @@ namespace ioh
             {
                 ++evaluations;
 
-                has_improved = meta_data.optimization_type(current_internal.y, current_best_internal.y);
-                if (has_improved)
+                bool has_internal_improved = meta_data.optimization_type(current_internal.y, current_best_internal.y);
+                if (has_internal_improved)
                 {
                     current_best_internal = current_internal;
                 }
 
-                has_improved = meta_data.optimization_type(current.y, current_best.y);
-                if (has_improved)
+                bool has_external_improved = meta_data.optimization_type(current.y, current_best.y);
+                if (has_external_improved)
                 {
                     y_unconstrained_best = y_unconstrained;
                     current_best = current;
 
                     if (objective.y == current.y)
                         optimum_found = true;
                 }
+
+                has_improved = has_internal_improved || has_external_improved;
             }
 
             std::string repr() const override