DTaaS CLI: Base structure and User add/Delete for Compose #578

astitva1905 · 2024-03-03T08:25:36Z

Creates new file for additional users ml-workspaces
Demos additions of a new user, across all relevant files

Tests:

To do:

Adding rules to conf file in user add -> (for next PR)
Starting new user container from within the user add cli (docker compose -f compose.users.yml up ) -> Done
No hardcoding config, instead users.yml.yemplate with recursive replace to fill in params -> Done
File path decision for global config file (~/.config/dtaas/config.yml) -> Changed to dtaas.toml (fornow assumed as always exists in DTaaS/cli/); Done.
Setting networks across compose files
Linting and testing
Packaging and publishing cli

docker/README.md

cli/add_users.py

docker/.env

prasadtalasila · 2024-03-06T16:42:42Z

@astitva1905
Please use click for CLI development.

cli/dtaas_cli/cmd.py

cli/dtaas_cli/pkg/users.py

cli/dtaas_cli/cmd.py

cli/dtaas_cli/pkg/users.py

prasadtalasila · 2024-03-14T12:19:01Z

@astitva1905
There is in-built support for TOML config format in python 3.11 onwards. Let us go with TOML config format (instead of YAML format) for DTaaS CLI. The suggested config is in wiki. Only the following part needs implementation in this PR.

# This is the config for DTaaS CLI

name = "Digital Twin as a Service (DTaaS)"
version = "0.1"
owner = "The INTO-CPS-Association"
git-repo = "https://github.com/into-cps-association/DTaaS.git"

[common]
# absolute path to the DTaaS application directory
path = "/home/dtaas/app"

[users]
# matching user info must present in this config file
add = ["username1","username2"] 
remove = ["username3"]

[users.username1]
email = "[email protected]"

[users.username2]
email = "[email protected]"

[users.username3]
email = "[email protected]"

[client.web]
config = "/home/dtaas/app/config/client/env.local.js"

Please name this file as dtaas.toml. We can postpone the default location of this file from this PR and always assume that dtaas.toml exists in the execution directory of dtaas CLI. If the file does not exist the CLI can create the same.

The format of the config subcommands are:

# inspiration "git config -h"
dtaas config [OPTIONS]
    -l --list     show TOML config file
    -g --get path    get the value of common.path variable
    -s --set path     set the value of common.path variable
    -u --unset path     delete the common.path variable from dtaas.toml file

prasadtalasila

Please see the comments.

cli/dtaas_cli/cmd.py

cli/dtaas_cli/pkg/dtaas.py

cli/dtaas_cli/pkg/helper.py

cli/setup.py

docker/.env

docker/conf.local

cli/dtaas_cli/pkg/dtaas.py

docker/compose.users.yml

prasadtalasila · 2024-03-14T13:38:25Z

The additional stack to be put in:

poetry project structure
pytest for tests
pylint for linting
pyright for type checking

Additional TODO: github workflow file to perform all the poetry steps including publish --dry-run step.

prasadtalasila · 2024-03-14T14:03:58Z

A suggestion to reduce the scope of this PR: Assume the correct formatting of dtaas.toml and skip the implementation of dtaas config... command.

codecov-commenter · 2024-03-17T06:48:15Z

Codecov Report

Merging #578 (edaea7f) into feature/distributed-demo (bf079f0) will increase coverage by 29.94%.
Report is 2 commits behind head on feature/distributed-demo.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@                      Coverage Diff                      @@
##           feature/distributed-demo     #578       +/-   ##
=============================================================
+ Coverage                     63.38%   93.33%   +29.94%     
=============================================================
  Files                            31        5       -26     
  Lines                           396       45      -351     
  Branches                         26        3       -23     
=============================================================
- Hits                            251       42      -209     
+ Misses                          130        0      -130     
+ Partials                         15        3       -12

Files	Coverage Δ
servers/execution/runner/src/app.controller.ts	`100.00% <ø> (ø)`
...rvers/execution/runner/src/config/configuration.ts	`100.00% <100.00%> (ø)`
servers/execution/runner/src/execaCMDRunner.ts	`86.66% <ø> (ø)`
...s/execution/runner/src/lifecycleManager.service.ts	`90.90% <ø> (ø)`
servers/execution/runner/src/queue.service.ts	`100.00% <ø> (ø)`

... and 31 files with indirect coverage changes

Components	Coverage Δ
Website	`∅ <ø> (∅)`
Lib Microservice	`∅ <ø> (∅)`

prasadtalasila · 2024-03-17T14:22:03Z

Let the forward-auth config update step (for conf.server and conf.local) be manual.
Use https://pypi.org/project/tomlkit/ for toml file parsing.

cli/src/pkg/users.py

cli/src/pkg/dtaas.py

cli/src/pkg/users.py

prasadtalasila

I need to check the working of the code. Please do add the developer (poetry...) commands to the README

prasadtalasila · 2024-03-23T12:43:05Z

cli/dtaas.toml

+
+[common]
+# absolute path to the DTaaS application directory
+server-dns = "domain.com"


prasadtalasila · 2024-03-23T12:43:44Z

cli/dtaas.toml

+[common]
+# absolute path to the DTaaS application directory
+server-dns = "domain.com"
+path = "/home/astitva/Desktop/yamlstuff"


/home/dtaas/DTaaS

prasadtalasila · 2024-03-23T12:44:02Z

cli/dtaas.toml

+
+[users]
+# matching user info must present in this config file
+add = ["astitvasehgal05","astitvasehgal19", "prasad"] 


user1,user2,user3

prasadtalasila · 2024-03-23T12:47:01Z

cli/src/cmd.py

+
+    configObj = dtaasPkg.Config()
+
+    err = userPkg.deleteUser(configObj)


Please use try...catch structure

prasadtalasila · 2024-03-23T12:48:02Z

cli/src/pkg/dtaas.py

+class Config:
+    def __init__(self):        
+        config, err = utils.importToml('dtaas.toml')
+        if err!=None:


Is try....catch iseful here?

prasadtalasila · 2024-03-23T12:49:59Z

cli/src/pkg/users.py

+import subprocess
+from . import utils
+
+def __getComposeConfig(username, server, DTaaSDirPath):


Nice notation for internal functions.

codeclimate · 2024-03-31T05:56:35Z

cli/src/pkg/users.py

+    cmdStr = " ".join(cmd)
+    subprocess.run(cmdStr, shell=True, check=False)
+
+def stopUserContainers(users):


Similar blocks of code found in 2 locations. Consider refactoring.

codeclimate · 2024-03-31T05:56:35Z

cli/src/pkg/users.py

+        compose['services'][username] = config
+    return None
+
+def startUserContainers(users):


Similar blocks of code found in 2 locations. Consider refactoring.

codeclimate · 2024-03-31T05:56:36Z

cli/src/pkg/config.py

+            return None, Exception("Config file error: Missing 'common' tag")
+        return conf['common'], None
+
+    def getUsers(self):


Similar blocks of code found in 2 locations. Consider refactoring.

codeclimate · 2024-03-31T05:56:36Z

cli/src/pkg/users.py

+
+    err = utils.exportYaml(compose, 'compose.users.yml')
+    if err is not None:
+        return err


Avoid too many return statements within this function.

codeclimate · 2024-03-31T05:56:36Z

cli/src/pkg/users.py

+
+    startUserContainers(userList)
+
+    return None


Avoid too many return statements within this function.

astitva1905 · 2024-03-31T08:22:00Z

cli/src/pkg/users.py

+        return err
+    path, err = configObj.getPath()
+    if err is not None:
+        return err


too many returns @prasadtalasila

prasadtalasila · 2024-03-31T08:26:53Z

Code Climate has analyzed commit 0516468 and detected 24 issues on this pull request.

Here's the issue category breakdown:
Category Count
Complexity 12
Duplication 8
Style 4

View more on Code Climate.

@astitva1905 please resolve these codeclimate issues as well. Thanks.

codeclimate · 2024-04-07T08:44:21Z

cli/src/pkg/config.py

+            return None, Exception("Config file error: The server dns isn't set in TOML")
+        return str(confCommon['server-dns']), None
+
+    def getAddUsersList(self):


Similar blocks of code found in 2 locations. Consider refactoring.

codeclimate · 2024-04-07T08:44:21Z

cli/tests/test_utils.py

+
+def test_export_yaml():
+
+    data = {


Similar blocks of code found in 2 locations. Consider refactoring.

codeclimate · 2024-04-07T08:44:21Z

cli/tests/test_utils.py

+    assert template==expected
+
+def test_import_yaml_compose():
+    expected = {


Similar blocks of code found in 2 locations. Consider refactoring.

codeclimate · 2024-04-07T08:44:21Z

cli/src/pkg/users.py

+
+    err = startUserContainers(userList)
+    if err is not None:
+        return err


Avoid too many return statements within this function.

codeclimate · 2024-04-07T08:44:21Z

cli/src/pkg/users.py

+        if 'services' not in compose:
+            return None
+        if username not in compose['services']:
+            return None


Avoid too many return statements within this function.

prasadtalasila · 2024-04-07T10:30:01Z

@astitva1905 some feedback on the CLI after trying in localhost scenario.

Can short option flags be added?
```
short flags:
  -h or --help
```
Handle the condition where the DTaaS is not installed
docker/.env has three users while compose has only two users. Can it be deleted?
what happens when new user is added without restarting forward-auth container?
DTaaS CLI does not add user directories in files/. This needs to be done in CLI itself? If the directory does exist, the directory structure needs to be checked.
When a user is added, add array emptied and add user is started again, the console shows the recent user being added.
When delete user is executed, even with empty user array being empty, the user added recently is deleted

When a user from original docker-compose file is attempted to be deleted, the following error comes:

dtaas admin user delete
no such service: kelvin
Error: Error while deleting users: failed to stop containers

codeclimate · 2024-04-10T16:30:06Z

cli/src/pkg/config.py

+        addUsersList = [ str(username) for username in confUsers['add']]
+        return addUsersList, None
+
+    def getDeleteUsersList(self):


Similar blocks of code found in 2 locations. Consider refactoring.

codeclimate · 2024-04-10T16:30:06Z

cli/tests/test_utils.py

+        } 
+    }
+
+    expected = {


Similar blocks of code found in 2 locations. Consider refactoring.

codeclimate · 2024-04-10T16:30:06Z

cli/src/pkg/users.py

+
+    err = utils.exportYaml(compose, 'compose.users.yml')
+    if err is not None:
+        return err


Avoid too many return statements within this function.

codeclimate · 2024-04-10T16:30:06Z

cli/src/pkg/users.py

+    if err is not None:
+        return err
+
+    return None


Avoid too many return statements within this function.

codeclimate · 2024-04-10T16:30:06Z

cli/tests/test_utils.py

+
+def test_replace_all():
+
+    template = {


Similar blocks of code found in 2 locations. Consider refactoring.

codeclimate · 2024-04-10T16:33:25Z

cli/src/pkg/utils.py

+        return None, Exception(f"Error while getting toml file: {filename}, " + str(err))
+    return config, None
+
+def replaceAll(obj, mapping):


Refactor this function to reduce its Cognitive Complexity from 18 to the 15 allowed.

cli/src/pkg/utils.py

codeclimate · 2024-04-10T16:33:25Z

cli/src/pkg/utils.py

+
+            obj[key], err = replaceAll(obj[key], mapping)
+            if err is not None:
+                return None, err


Avoid too many return statements within this function.

codeclimate · 2024-04-10T16:33:25Z

cli/src/pkg/utils.py

+            if err is not None:
+                return None, err
+
+        return obj, None


Avoid too many return statements within this function.

codeclimate · 2024-04-13T12:14:22Z

cli/src/pkg/utils.py

+        return None, Exception(f"Error while getting toml file: {filename}, " + str(err))
+    return config, None
+
+def replaceAll(obj, mapping):


Refactor this function to reduce its Cognitive Complexity from 16 to the 15 allowed.

codeclimate · 2024-04-13T12:14:22Z

cli/src/pkg/utils.py

+
+
+
+def checkError(err):


Rename function "checkError" to match the regular expression ^[a-z_][a-z0-9_]{2,}$.

codeclimate · 2024-04-13T12:14:22Z

cli/src/pkg/utils.py

+        return None, Exception(f"Error while getting toml file: {filename}, " + str(err))
+    return config, None
+
+def replaceAll(obj, mapping):


Rename function "replaceAll" to match the regular expression ^[a-z_][a-z0-9_]{2,}$.

codeclimate · 2024-04-13T12:14:22Z

cli/src/pkg/utils.py

+                return None, err
+        return obj, None
+
+    return None, Exception("Config substition failed: Object format not valid")


Avoid too many return statements within this function.

codeclimate · 2024-04-13T12:14:22Z

cli/src/cmd.py

+    return
+
+#### user group commands
+@user.command()


Similar blocks of code found in 2 locations. Consider refactoring.

codeclimate · 2024-04-13T12:17:33Z

cli/src/pkg/utils.py

+
+    return None, Exception("Config substition failed: Object format not valid")
+
+def replaceString(obj, mapping):


Rename function "replaceString" to match the regular expression ^[a-z_][a-z0-9_]{2,}$.

cli/src/pkg/utils.py

codeclimate · 2024-04-13T12:17:33Z

cli/src/pkg/users.py

+
+    return None
+
+def deleteUser(configObj):


Rename function "deleteUser" to match the regular expression ^[a-z_][a-z0-9_]{2,}$.

codeclimate · 2024-04-13T12:17:34Z

cli/src/cmd.py

+        raise click.ClickException("Error while adding users: " + str(err))
+    click.echo("Users added successfully")
+
+@user.command()


Similar blocks of code found in 2 locations. Consider refactoring.

codeclimate · 2024-04-13T12:17:34Z

cli/src/pkg/config.py

+            return self.data,None
+        return None, Exception("Config not initialised")
+
+    def getCommon(self):


Similar blocks of code found in 2 locations. Consider refactoring.

codeclimate · 2024-04-14T05:30:13Z

cli/src/pkg/users.py

+        return Exception("failed to stop containers")
+    return None
+
+def addUsers(configObj):


Rename function "addUsers" to match the regular expression ^[a-z_][a-z0-9_]{2,}$.

codeclimate · 2024-04-14T05:30:13Z

cli/src/pkg/users.py

+import shutil
+from src.pkg import utils
+
+def getComposeConfig(username, server, path):


Rename function "getComposeConfig" to match the regular expression ^[a-z_][a-z0-9_]{2,}$.

codeclimate · 2024-04-14T05:30:13Z

cli/src/cmd.py

+""" This file defines all cli entrypoints for dtaas"""
+
+import click
+#from . import service


Remove this commented out code.

codeclimate · 2024-04-14T05:30:13Z

cli/src/pkg/users.py

+
+    return config, None
+
+def createUserFiles(users, filePath):


Rename function "createUserFiles" to match the regular expression ^[a-z_][a-z0-9_]{2,}$.

codeclimate · 2024-04-14T05:30:13Z

cli/src/pkg/users.py

+        return Exception("failed to start containers")
+    return None
+
+def stopUserContainers(users):


Rename function "stopUserContainers" to match the regular expression ^[a-z_][a-z0-9_]{2,}$.

codeclimate · 2024-04-14T09:00:14Z

cli/src/pkg/users.py

+
+    return None
+
+def deleteUser(configObj):


Function deleteUser has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.

codeclimate · 2024-04-14T09:00:14Z

cli/src/pkg/utils.py

+        return None, Exception(f"Error while getting toml file: {filename}, " + str(err))
+    return config, None
+
+def replaceAll(obj, mapping):


Function replaceAll has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.

codeclimate · 2024-04-14T09:00:14Z

cli/tests/test_cli.py

+import subprocess
+
+
+def test_add_user_cli():


Similar blocks of code found in 2 locations. Consider refactoring.

codeclimate · 2024-04-14T09:00:14Z

cli/tests/test_cli.py

+    result =subprocess.run(["dtaas admin user add"], shell=True)
+    assert result.returncode == 0
+
+def test_delete_user_cli():


Similar blocks of code found in 2 locations. Consider refactoring.

codeclimate · 2024-04-20T11:50:59Z

cli/README.md

+```
+### Additional Points to Remember
+
+- The base DTaaS system should be up and running before adding/deleting users with the CLI


Line length

codeclimate · 2024-04-20T11:50:59Z

cli/README.md

+- The base DTaaS system should be up and running before adding/deleting users with the CLI
+
+- The _user add_ CLI will add and start a container for a new user.
+  It can also start a container for an existing user if that container was somehow stopped.


Line length

codeclimate · 2024-04-20T11:50:59Z

cli/README.md

+
+- The _user add_ CLI will add and start a container for a new user.
+  It can also start a container for an existing user if that container was somehow stopped.
+  It shows a _Running_ status for existing user containers that are already up and running,


Line length

codeclimate · 2024-04-20T11:50:59Z

cli/README.md

+  It shows a _Running_ status for existing user containers that are already up and running,
+  it doesn't restart them.
+
+- Configure the _server-dns_ in the _dtaas.toml_ file with the domain name of your server.


Line length

codeclimate · 2024-04-20T11:50:59Z

cli/README.md

+- Configure the _server-dns_ in the _dtaas.toml_ file with the domain name of your server.
+  If you want to bring up the server locally, please set this to _"localhost"_.
+
+- _user add_ and _user delete_ CLIs return an error if the _add_ and _delete_ lists in


Line length

codeclimate · 2024-04-20T11:56:30Z

cli/README.md

+- _user add_ and _user delete_ CLIs return an error if the _add_ and _delete_ lists in
+  _dtaas.toml_ are empty, respectively.
+
+- Currently the _email_ fields for each user in dtaas.toml are not in use, and are not necessary


Line length

codeclimate · 2024-04-20T11:56:30Z

cli/README.md

+  _dtaas.toml_ are empty, respectively.
+
+- Currently the _email_ fields for each user in dtaas.toml are not in use, and are not necessary
+  to fill in. These emails must be configured manually for each user in the docker/conf.local or


Line length

codeclimate · 2024-04-20T11:56:30Z

cli/README.md

+
+- Currently the _email_ fields for each user in dtaas.toml are not in use, and are not necessary
+  to fill in. These emails must be configured manually for each user in the docker/conf.local or
+  docker/conf.server files and the _traefik-forward-auth_ container must be restarted as described above.


Line length

codeclimate · 2024-04-20T11:56:30Z

cli/README.md

+
+```bash
+dtaas admin user delete
+```


Fenced code blocks should be surrounded by blank lines

codeclimate · 2024-04-21T08:03:44Z

cli/DEVELOPER.README.md

+  singleton Config class, which is used throughout the CLI. Additionally,
+  it contains the handling functions for each CLI. These functions perform
+  the actual operations that the CLI command is responsible for. It also
+  has helper functions that can be used across the CLI. 


Trailing spaces

codeclimate · 2024-04-21T08:03:44Z

cli/DEVELOPER.README.md

+
+## Poetry
+
+We use [Poetry Package](https://python-poetry.org/docs/) to manage dependencies and build the CLI. The configuration file for this is


Line length

codeclimate · 2024-04-27T19:52:49Z

cli/tests/test_utils.py

+
+    assert filecmp.cmp('tests/compose.users.test.yml', 'tests/compose.users.exp.yml')
+
+def getReplaceAllObject(stringval1, stringval2, stringval3, listval1, listval2, listval3):


Function getReplaceAllObject has 6 arguments (exceeds 4 allowed). Consider refactoring.

codeclimate · 2024-04-27T19:52:49Z

cli/DEVELOPER.md

+The CLI is published to [PyPI](https://pypi.org/).
+Once new changes to the CLI are merged to the DTaaS
+repository, the CLI is also published to the official
+DTaaS PyPI account. 


Trailing spaces

cli/README.md

cli/requirements.txt

cli/DEVELOPER.md

cli/pyproject.toml

cli/DEVELOPER.md

codeclimate · 2024-05-01T15:23:07Z

.pylintrc

+[MISCELLANEOUS]
+
+# List of note tags to take in consideration, separated by a comma.
+notes=FIXME,


FIXME found

codeclimate · 2024-05-01T15:23:07Z

.pylintrc

+
+# List of note tags to take in consideration, separated by a comma.
+notes=FIXME,
+      XXX,


codeclimate · 2024-05-01T15:23:07Z

.pylintrc

+# List of note tags to take in consideration, separated by a comma.
+notes=FIXME,
+      XXX,
+      TODO


codeclimate · 2024-05-01T15:23:07Z

cli/DEVELOPER.md

+
+## Setup
+
+


Multiple consecutive blank lines

codeclimate · 2024-05-01T15:23:07Z

cli/README.md

+```toml
+[users]
+# matching user info must present in this config file
+add = ["username1","username2", "username3"] 


Trailing spaces

codeclimate · 2024-05-01T15:42:10Z

cli/src/pkg/config.py

+    def getFromConfig(self, key):
+        """Gets the specific key from config"""
+        conf, err = self.getConfig()
+        if err is not None:


Identical blocks of code found in 5 locations. Consider refactoring.

codeclimate · 2024-05-01T15:42:11Z

cli/src/pkg/config.py

+    def getStringFromCommon(self, key):
+        """Gets the specific string key from config.common"""
+        confCommon, err = self.getCommon()
+        if err is not None:


Identical blocks of code found in 5 locations. Consider refactoring.

codeclimate · 2024-05-01T15:42:11Z

cli/src/pkg/config.py

+    def getStringListFromUsers(self, key):
+        """Gets the specific key as a list of strings from config.users"""
+        confUsers, err = self.getUsers()
+        if err is not None:


Identical blocks of code found in 5 locations. Consider refactoring.

codeclimate · 2024-05-01T15:42:11Z

cli/src/pkg/utils.py

+def replaceList(arr, mapping):
+    for ind, val in enumerate(arr):
+        arr[ind], err = replaceAll(val, mapping)
+        if err is not None:


Identical blocks of code found in 5 locations. Consider refactoring.

codeclimate · 2024-05-01T15:42:11Z

cli/src/pkg/utils.py

+        if not isinstance(key,str):
+            return None, Exception("Config substitution failed: Key is not a string")
+        dictionary[key], err = replaceAll(dictionary[key], mapping)
+        if err is not None:


Identical blocks of code found in 5 locations. Consider refactoring.

codeclimate · 2024-05-01T16:31:35Z

Code Climate has analyzed commit 6d5deb0 and detected 0 issues on this pull request.

View more on Code Climate.

codeclimate bot reviewed Mar 3, 2024

View reviewed changes

docker/README.md Outdated Show resolved Hide resolved

docker/README.md Outdated Show resolved Hide resolved

docker/README.md Outdated Show resolved Hide resolved

prasadtalasila reviewed Mar 6, 2024

View reviewed changes

cli/add_users.py Outdated Show resolved Hide resolved

cli/add_users.py Outdated Show resolved Hide resolved

cli/add_users.py Outdated Show resolved Hide resolved

cli/add_users.py Outdated Show resolved Hide resolved

docker/.env Outdated Show resolved Hide resolved

codeclimate bot reviewed Mar 14, 2024

View reviewed changes

prasadtalasila reviewed Mar 14, 2024

View reviewed changes

astitva1905 force-pushed the useradd branch from edaea7f to 6739fbc Compare March 23, 2024 12:23

codeclimate bot reviewed Mar 23, 2024

View reviewed changes

cli/src/pkg/users.py Outdated Show resolved Hide resolved

cli/src/pkg/users.py Outdated Show resolved Hide resolved

cli/src/pkg/dtaas.py Outdated Show resolved Hide resolved

cli/src/pkg/users.py Outdated Show resolved Hide resolved

cli/src/pkg/users.py Outdated Show resolved Hide resolved

prasadtalasila reviewed Mar 23, 2024

View reviewed changes

astitva1905 changed the title ~~New User ML Workspace Addition to docker deploy~~ DTaaS CLI: Base structure and User add/Delete for Compose Mar 24, 2024

astitva1905 force-pushed the useradd branch from 6739fbc to 0516468 Compare March 31, 2024 05:55

codeclimate bot reviewed Mar 31, 2024

View reviewed changes

astitva1905 commented Mar 31, 2024

View reviewed changes

astitva1905 force-pushed the useradd branch from 0516468 to 5395d07 Compare April 7, 2024 08:43

codeclimate bot reviewed Apr 7, 2024

View reviewed changes

codeclimate bot reviewed Apr 10, 2024

View reviewed changes

codeclimate bot reviewed Apr 13, 2024

View reviewed changes

codeclimate bot reviewed Apr 14, 2024

View reviewed changes

Astitva added 3 commits April 20, 2024 17:19

Docker system restructure

317322c

PR Review

52079dd

Users compose file

7f41107

astitva1905 force-pushed the useradd branch from 0d0f17c to 2c50c5f Compare April 20, 2024 11:49

codeclimate bot reviewed Apr 20, 2024

View reviewed changes

Restores server/config/gateway files

b54dabd

codeclimate bot reviewed Apr 20, 2024

View reviewed changes

Astitva added 2 commits April 20, 2024 17:29

Restores docker/ files

bd29641

Developer docs

1e2634b

codeclimate bot reviewed Apr 21, 2024

View reviewed changes

Astitva added 2 commits April 28, 2024 00:56

Developer readme

9e9923f

Code climate issues 1

78bece3

codeclimate bot reviewed Apr 27, 2024

View reviewed changes

Astitva added 6 commits April 28, 2024 01:41

replaceAll refactor

a913f6e

Codeclimate issues 2

613d107

Final codeclimate resolves

63e67a7

TOML cleanup

6458510

testing caveat mention

9f341a2

Poetry shell info

4ca6a95

prasadtalasila reviewed Apr 28, 2024

View reviewed changes

final PR Review changes

b464823

codeclimate bot reviewed May 1, 2024

View reviewed changes

Astitva added 2 commits May 1, 2024 21:03

codeclimate issues

5e56796

duplication threshold increase

e5fffd4

codeclimate bot reviewed May 1, 2024

View reviewed changes

Astitva added 6 commits May 1, 2024 21:14

duplication threshold increase

c9b9888

duplication threshold increase

a69a090

count threshold increase

70a4bfb

removes old requirements.txt

157ec13

final changes

a166037

poetry.lock fixed after dev dependencies added

6d5deb0

prasadtalasila merged commit 210af87 into INTO-CPS-Association:feature/distributed-demo May 1, 2024


		configObj = dtaasPkg.Config()

		err = userPkg.deleteUser(configObj)


		return None, Exception("Config substition failed: Object format not valid")

		def replaceString(obj, mapping):


		## Poetry

		We use [Poetry Package](https://python-poetry.org/docs/) to manage dependencies and build the CLI. The configuration file for this is


		assert filecmp.cmp('tests/compose.users.test.yml', 'tests/compose.users.exp.yml')

		def getReplaceAllObject(stringval1, stringval2, stringval3, listval1, listval2, listval3):

DTaaS CLI: Base structure and User add/Delete for Compose #578

DTaaS CLI: Base structure and User add/Delete for Compose #578

Conversation

astitva1905 commented Mar 3, 2024 • edited Loading

prasadtalasila commented Mar 6, 2024

prasadtalasila commented Mar 14, 2024 • edited Loading

prasadtalasila left a comment

Choose a reason for hiding this comment

prasadtalasila commented Mar 14, 2024

prasadtalasila commented Mar 14, 2024

codecov-commenter commented Mar 17, 2024

Codecov Report

prasadtalasila commented Mar 17, 2024

prasadtalasila left a comment

Choose a reason for hiding this comment

prasadtalasila Mar 23, 2024

Choose a reason for hiding this comment

prasadtalasila Mar 23, 2024

Choose a reason for hiding this comment

prasadtalasila Mar 23, 2024

Choose a reason for hiding this comment

prasadtalasila Mar 23, 2024

Choose a reason for hiding this comment

prasadtalasila Mar 23, 2024

Choose a reason for hiding this comment

prasadtalasila Mar 23, 2024

Choose a reason for hiding this comment

codeclimate bot Mar 31, 2024

Choose a reason for hiding this comment

codeclimate bot Mar 31, 2024

Choose a reason for hiding this comment

codeclimate bot Mar 31, 2024

Choose a reason for hiding this comment

codeclimate bot Mar 31, 2024

Choose a reason for hiding this comment

codeclimate bot Mar 31, 2024

Choose a reason for hiding this comment

astitva1905 Mar 31, 2024

Choose a reason for hiding this comment

prasadtalasila commented Mar 31, 2024

codeclimate bot Apr 7, 2024

Choose a reason for hiding this comment

codeclimate bot Apr 7, 2024

Choose a reason for hiding this comment

codeclimate bot Apr 7, 2024

Choose a reason for hiding this comment

codeclimate bot Apr 7, 2024

Choose a reason for hiding this comment

codeclimate bot Apr 7, 2024

Choose a reason for hiding this comment

prasadtalasila commented Apr 7, 2024

codeclimate bot Apr 10, 2024

Choose a reason for hiding this comment

codeclimate bot Apr 10, 2024

Choose a reason for hiding this comment

codeclimate bot Apr 10, 2024

Choose a reason for hiding this comment

codeclimate bot Apr 10, 2024

Choose a reason for hiding this comment

codeclimate bot Apr 10, 2024

Choose a reason for hiding this comment

codeclimate bot Apr 10, 2024

Choose a reason for hiding this comment

codeclimate bot Apr 10, 2024

Choose a reason for hiding this comment

codeclimate bot Apr 10, 2024

Choose a reason for hiding this comment

codeclimate bot Apr 13, 2024

Choose a reason for hiding this comment

codeclimate bot Apr 13, 2024

Choose a reason for hiding this comment

codeclimate bot Apr 13, 2024

Choose a reason for hiding this comment

codeclimate bot Apr 13, 2024

Choose a reason for hiding this comment

codeclimate bot Apr 13, 2024

Choose a reason for hiding this comment

codeclimate bot Apr 13, 2024

Choose a reason for hiding this comment

codeclimate bot Apr 13, 2024

astitva1905 commented Mar 3, 2024 •

edited

Loading

prasadtalasila commented Mar 14, 2024 •

edited

Loading