Updates npm packages of lib microservice #112
Conversation
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## feature/distributed-demo #112 +/- ##
============================================================
- Coverage 66.66% 66.38% -0.29%
============================================================
Files 42 7 -35
Lines 537 119 -418
Branches 31 4 -27
============================================================
- Hits 358 79 -279
+ Misses 160 37 -123
+ Partials 19 3 -16
... and 36 files with indirect coverage changes
|
|
@OliverGeneser Thanks for the PR. Please do check for different versions of transitive dependencies to make sure that they are of same version. The npm seems might have a way to enforce use of same dependency version in all dependencies. Can you check if it helps? Please do also check the licenses for the all the packages to see if the packages can be used with GPL Version 3 used by DTaaS software. This github resource might help. |
|
Please check the commands given in issue #109 to see if the vulnerabilities have been taken care of. |
OliverGeneser
changed the title
|
@prasadtalasila This PR fixes 47 vulnerabilities and most relates to a DOS vulnerability in semver and word-wrap or a Resource Consumption vulnerability in graphql |
prasadtalasila
changed the title
prasadtalasila
changed the title
There was a problem hiding this comment.
Please check the comments posted on issue #109 as well. Thanks.
| @@ -8,7 +8,9 @@ import { IFilesService } from "../interfaces/files.service.interface"; | |||
| @Injectable() | |||
| export default class LocalFilesService implements IFilesService { | |||
| // eslint-disable-next-line no-useless-constructor | |||
| constructor(private configService: ConfigService) {} | |||
| constructor(private configService: ConfigService) { | |||
| // Empty constructor | |||
There was a problem hiding this comment.
Why is this comment line added?
servers/lib/package.json
Outdated
| "@nestjs/platform-express": "^10.2.6", | ||
| "axios": "^1.5.0", | ||
| "dotenv": "^16.3.1", | ||
| "eslint-plugin-import": "^2.28.1", |
There was a problem hiding this comment.
These two eslint packages can go into devDependencies.
There was a problem hiding this comment.
The major changes seem to be:
"dependencies": {
"@apollo/server": "^4.9.3",
"express": "^4.17.1",
"graphql-scalars": "^1.22.2",
"mock-fs": "^5.2.0",
"reflect-metadata": "^0.1.13",
"type-graphql": "^2.0.0-beta.2"
},
"devDependencies": {
"supertest": "^6.1.3",
"ts-node": "^10.0.0",
},
"peerDependencies": {
"graphql-scalars": "^1.22.2"
}
These packages are new additions. Why do we need them?
Also the graphql-scalars is in two places - devDependencies and peerDependencies. If needed, please add it at the right place.
servers/lib/package.json
Outdated
| "@types/jest": "^29.5.3", | ||
| "@types/node": "18.11.18", | ||
| "@types/jest": "^29.5.5", | ||
| "@types/node": "20.6.5", |
|
@OliverGeneser , please rebase your code to the latest commit on the I see two changes in the packages.
|
…ture/distributed-demo
|
@prasadtalasila |
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
|
@OliverGeneser, using any version is vague. Please change the |
|
Code Climate has analyzed commit 5e98069 and detected 0 issues on this pull request. View more on Code Climate. |
No description provided.