Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runner limit permitted commands #1016

Conversation

prasadtalasila
Copy link
Contributor

@prasadtalasila prasadtalasila commented Oct 28, 2024

Limit permitted commands in Runner

  • Limit permitted commands to those listed in runner.yaml config file.
  • Fixes API calls to send correct invalid status for both non-existing and not permitted commands

Type of Change

  • New feature
  • Bug fix
  • Documentation update
  • Refactoring
  • Security patch
  • UI/UX improvement

Description

Previously, any commands placed in script directory could be executed. Now, only the listed commands in the configuration file are executed. This is a security improvement.

Testing

The end-to-end tests have been performed. Unit tests are completed only for query validation code.

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • unit tests are missing.
  • I have made corresponding changes to the documentation.

@prasadtalasila prasadtalasila added this to the Release v0.6.0 milestone Oct 28, 2024
Copy link

codeclimate bot commented Oct 28, 2024

Code Climate has analyzed commit b127dc7 and detected 0 issues on this pull request.

View more on Code Climate.

@prasadtalasila prasadtalasila merged commit a42678a into INTO-CPS-Association:feature/distributed-demo Oct 28, 2024
2 checks passed
@prasadtalasila prasadtalasila deleted the runner-limit-permitted-commands-rebased-on-feature-distributed-demo branch October 28, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant