chore(jdt): bump jdt version and fix testcase accordingly #3739
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3731
The fix was already as a todo there. JDT allows only for the latest java version preview features. Updating to version 15 and disabling preview features works for now. As soon as we implement java 15 preview features, we need to reenable them.
As we discussed somewhere, some testhelpers could be super useful.
This could remove a lot of hard coded versions from the test code. In many cases a latest version is what we want, but we simply write the latest current version. The supported jdt versions has some kind of api see https://github.com/eclipse/eclipse.jdt.core/blob/master/org.eclipse.jdt.core/model/org/eclipse/jdt/core/JavaCore.java#L3144
Location
I have no clue where testhelpers are placed inside the test folder. Any hints?
Currently SpoonTestHelpers is in spoon/test/ but maybe a clear folder inside /test for testhelpers is way more obvious to use?