review: refactor: refactor cloning code to increase extendability #1878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monperrus
changed the title
monperrus
force-pushed
the
refactor-clone
branch
from
eb9346c to
39a967e
Compare
monperrus
changed the title
monperrus
force-pushed
the
refactor-clone
branch
2 times, most recently
from
77db20d to
69958ed
Compare
monperrus
force-pushed
the
refactor-clone
branch
from
69958ed to
99cc313
Compare
monperrus
changed the title
| @@ -134,4 +136,24 @@ | |||
| protected <T extends CtElement> void addClone(Map<String, T> targetMap, String key, T value) { | |||
| targetMap.put(key, clone(value)); | |||
| } | |||
|
|
|||
| private CtElement initialTopLevel; | |||
| private CtElement cloneTopLevel; | |||
There was a problem hiding this comment.
What is purpose of these two members? They are actually useless - not accessible.
| private CtElement initialTopLevel; | ||
| private CtElement cloneTopLevel; | ||
|
|
||
| public void tailor(spoon.reflect.declaration.CtElement element, spoon.reflect.declaration.CtElement other) { |
|
done :-)
|
|
you're right. not needed anymore since we use an inner class in "tailor". changed.
|
|
API changes: 1 (Detected by Revapi) Old API: fr.inria.gforge.spoon:spoon-core:jar:6.2.0-20180224.163820-108 / New API: fr.inria.gforge.spoon:spoon-core:jar:6.2.0-SNAPSHOT
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to be able, in the future, to slightly adapt the cloning behavior without touching the generator of cloning code.
In particular, it will be useful for #1869