Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: getDocComment() returns asterisk (*) and spaces before comment #1841

Merged
merged 2 commits into from
Feb 9, 2018

Conversation

manic-coder
Copy link
Contributor

Added toString() method to CtJavaDocImpl.java to handle getDocComment()

@surli
Copy link
Collaborator

surli commented Feb 9, 2018

Hi @manic-coder you're almost there for having the PR merged ;)
We're using a checkstyle in Spoon to guarantee that we all share the same codestyle: the build is failing here because there's some errors on your checkstyle.
You can see the errors on https://travis-ci.org/INRIA/spoon/jobs/339338677:

[INFO] Starting audit...
/home/travis/build/INRIA/spoon/src/main/java/spoon/support/reflect/code/CtJavaDocTagImpl.java:0: error: File does not end with a newline.
/home/travis/build/INRIA/spoon/src/main/java/spoon/support/reflect/code/CtJavaDocTagImpl.java:90:32: error: '(' is preceded with whitespace.

I advice you to run mvn verify -DskipTests before submitting changes to be sure the checkstyle is fixed :)

@manic-coder
Copy link
Contributor Author

Hi @surli I've made the requisite changes and the Travis CI is building now :)

I hope it can be merged now. On another note, I'm having trouble running the maven command you recommended (mvn verify -Dskiptests). I get:

[ERROR] Please refer to C:\Users\Shantanu\IdeaProjects\spoon\target\surefire-reports for the individual test results.
[ERROR] Please refer to dump files (if any exist) [date]-jvmRun[N].dump, [date].dumpstream and [date]-jvmRun[N].dumpstream.
[ERROR] The forked VM terminated without properly saying goodbye. VM crash or System.exit called?

The dump file states:
Killing self fork JVM. Maven process died.

What should I do?

@surli
Copy link
Collaborator

surli commented Feb 9, 2018

I'll merge the PR, thanks for that! I honestly have no idea about what happened when you execute the maven command...

@surli surli merged commit b547c30 into INRIA:master Feb 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants