fix: Shadow classes should be interpreted according to their kind (enum, interface, etc) #1806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surli
changed the title
|
Thank you. |
tdurieux
reviewed
Jan 4, 2018
| @@ -61,7 +61,15 @@ public void visitPackage(Package aPackage) { | |||
| visitField(field); | |||
| } | |||
| for (Class<?> aClass : clazz.getDeclaredClasses()) { | |||
| visitClass(aClass); | |||
| if (aClass.isAnnotation()) { | |||
| visitAnnotationClass((Class<Annotation>) aClass); | |||
There was a problem hiding this comment.
I think it will produce class cast exception.
The correct type is Class<? extends Annotation>
There was a problem hiding this comment.
I get this code from there:
and apparently it's used for 2 years... But PR with a failing test case is welcome :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failing test for #1791.
As you can see, test fails, for the enum from jar.
Class from EnumJar.jar: