Re-introduce jQuery-UI and jQuery-migrate for ILIAS 10 #8928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds `jquery-ui` and `jquery-migrate` as composer dependency. Usage: * Used for requesting and auto-completing user searches. For example, for adding users to roles (including memberships), test participants, survey participants, chat participants and many more. Wrapped By: * Not applicable Reasoning: * Without this functionality, usability will be significantly worse in many places where users need to be located and identified by their surname / first name or email address. To use the remaining functions, you would always have to have correct/complete data about users with whom something is to be done. This lack can't be understood by any end user. * This libraries will be used for the last time with ILIAS 10, as we prefer a different solution in the UI framework from ILIAS 11 onwards. * We are convinced that we still have so much jquery code that we still need `jquery-migrate`. Maintenance `jquery-ui`: * The library has been stable for a long time. * The library is regularly updated and maintained (313 contributors) * License: MIT Maintenance `jquery-migrate`: * The library has been stable for a long time. * The library is regularly updated and maintained (29 contributors) * License: MIT Links: * NPM: [https://www.npmjs.com/package/jquery-ui](https://www.npmjs.com/package/jquery-ui) * GitHub: [github.com/jquery/jquery-ui](github.com/jquery/jquery-ui) * NPM: [https://www.npmjs.com/package/jquery-migrate](https://www.npmjs.com/package/jquery-migrate) * GitHub: [github.com/jquery/jquery-migrate](github.com/jquery/jquery-migrate)
oliversamoila
added
jour fixe
dependencies
mjansenDatabay
changed the title
|
Thank you for proposing this @oliversamoila ! I would suggest to not introduce these dependencies again. It is far too much overhead for one little input, as far as I can see the needed functionality should be achievable with a few lines of js. If nobody wants to look into it, I will look into it before february 14th 2025. If I see that it gets bigger than expected, I will take care of this PR. Best, |
|
Jour Fixe, 03 FEB 2025: We postpone the decision about this PR to the next JF and hope that Stephan will know more about the feasibility of his approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
jquery-uiandjquery-migrateas NPM dependency.Usage:
Wrapped By:
Reasoning:
jquery-migrate.Maintenance
jquery-ui:Maintenance
jquery-migrate:Links: