-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete dataset display where analysis was deleted. #623
Comments
Observed a case in nemoanalytics where the user_saved analysis files + directory are missing. Dataset can be found near bottom of the link redirect in the opening comment of #847. Unsure if "delete_analysis" was run. One caveat to this, is that the original dataset supposedly has no metadata, so curation cannot happen unless it came from an analysis. |
Adding some commented-out code that would remove any displays where this analysis ID, and would cascade to remove dataset_preference and layout_displays entries with the same display ID. However I am leaving it commented out because I'm not sure if it is worse to have the display "mysteriously" vanish (from a user's perspective), or have the display show an error when drawn. What I am also doing is adding better error-handling when analysis file paths are retrieved, so a user showing a display with a deleted analysis would have a better idea of the error |
Probably need to warn a user when they delete an analysis that there are displays depending on that analysis, so they can decide if they still want to remove it. |
That makes sense. |
Is there any cleanup we can do to make the error message related to this look nicer? EDITED - removing image for security reasons |
oof, yea I'll fix that. And we definitely should not be showing the data structure paths. |
@JPReceveur care to check the new message. It's a generic "Can not retrieve AnnData object" error. |
Adjusted error message to better reflect the actual issue (analysis h5ad not found) |
@JPReceveur had a situation where a dataset display did not show because the corresponding analysis h5ad was not found. The "user_saved" analysis ID directory was actually not present on the filesystem, leading me to believe that the user deleted the analysis. Currently our "delete analysis" CGI script just removes the analysis directory, but does not delete any corresponding dataset displays using this analysis.
Low priority since it seems like an edge case.
The text was updated successfully, but these errors were encountered: