Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installed Software show no instances #48

Closed
frankie64 opened this issue Dec 18, 2024 · 3 comments · Fixed by #53
Closed

installed Software show no instances #48

frankie64 opened this issue Dec 18, 2024 · 3 comments · Fixed by #53
Assignees
Labels
bug Something isn't working

Comments

@frankie64
Copy link

Hi,

Sometimes the filter 'installed software' shows not the devices.

for instance:
Software '[Microsoft Visual C++ 2015-2022 Redistributable (x64) - 14.38.33135]' has 2 installed instances.

If I click on this no devices will be show. for other software it works.

thx for help

@MartVisser MartVisser added the bug Something isn't working label Dec 23, 2024
@MartVisser
Copy link

Hi @frankie64

Thanks for reporting the bug. I can reproduce the bug. The ‘+’ character doesn't show up in the search filter on the installation page. Looks like it's because the URL is not being encoded.

With the URL /plugins/slm/installations/?q=Microsoft Visual C++ 2015-2022 Redistributable (x64) the search filter is:
Screenshot 2024-12-23 at 11 50 54

If I manually modify the URL to a encoded version /plugins/slm/installations/?q=Microsoft+Visual+C%2B%2B+2015-2022+Redistributable+(x64) the search filter is:
Screenshot 2024-12-23 at 11 50 49

We will try to fix this bug after the holiday period. We are also accepting PRs.

@frankie64
Copy link
Author

frankie64 commented Dec 23, 2024 via email

@wkoot wkoot self-assigned this Feb 11, 2025
wkoot added a commit that referenced this issue Feb 11, 2025
@wkoot wkoot linked a pull request Feb 11, 2025 that will close this issue
wkoot added a commit that referenced this issue Feb 11, 2025
@wkoot
Copy link
Collaborator

wkoot commented Feb 11, 2025

I have fixed the url encoding error, but I believe that there might still be some unexpected behaviour here.

This bug only appears on Installations columns, which only appear in the Software Products and Versions tables.
They link to the Software Product Installations table, with a search query simply referring to the originating object name.
So if you navigate from installations in the products or versions table, you search on product name or version name respectively.

The catch here is that the search is performed by simply appending a ?q=(name) to the url for installations.
This means that any search field is being matched for this query; if there are partial matches, they will also be included.
Unless there is a way to directly display a queryset, or searching on specific column values only, I don't see a good solution.

Some examples of unexpected search clashes (although their counts will be accurate):

  • Software product "alpine", version "3.12" & product "python", version "3.12"
  • Software product "alpine" & product "postgres container", version "17-alpine"

wkoot added a commit that referenced this issue Feb 11, 2025
wkoot added a commit that referenced this issue Feb 13, 2025
wkoot added a commit that referenced this issue Feb 13, 2025
wkoot added a commit that referenced this issue Feb 13, 2025
wkoot added a commit that referenced this issue Feb 13, 2025
wkoot added a commit that referenced this issue Feb 13, 2025
@wkoot wkoot closed this as completed in #53 Feb 13, 2025
@wkoot wkoot closed this as completed in 306d853 Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants