-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Email file memory fix #79
Conversation
…MIME parser to avoid reading the entire MIME file into memory
@rtobar looks like a problem in the python 3.7 build environment |
@rtobar the travis CI fails for python 3.7 only. I do not know why |
The problem with 3.7 seems like a Travis environment issue that has been communicated to the setuptools people: pypa/setuptools#3118. I think we can safely ignore this for the time being, I'll pin the setuptools version later on the master branch to avoid this issue. As for the code changes, they only touch ALMA-related code. If you're happy then I'm happy; in other words, I'll merge straight away. |
When I ported the old code from using the rc822 module to using the email instead I did not realise that I had introduced a new problem. The old rf822 module was very memory efficient where as the new email modules appears to read the entire file contents into memory. I have written a simple file parer that only pareses the MIME file primary header unit. This is all we need for ALMA when trying to determine if the file is a
multipart/mixed
ormultipart/related
.