Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email file memory fix #79

Merged
merged 9 commits into from
Mar 16, 2022
Merged

Email file memory fix #79

merged 9 commits into from
Mar 16, 2022

Conversation

smclay
Copy link
Contributor

@smclay smclay commented Mar 7, 2022

When I ported the old code from using the rc822 module to using the email instead I did not realise that I had introduced a new problem. The old rf822 module was very memory efficient where as the new email modules appears to read the entire file contents into memory. I have written a simple file parer that only pareses the MIME file primary header unit. This is all we need for ALMA when trying to determine if the file is a multipart/mixed or multipart/related.

@coveralls
Copy link

coveralls commented Mar 7, 2022

Coverage Status

Coverage increased (+0.06%) to 69.606% when pulling 444574c on smclay:email-file-memory-fix into e7fc383 on ICRAR:master.

@smclay
Copy link
Contributor Author

smclay commented Mar 7, 2022

@rtobar looks like a problem in the python 3.7 build environment

@smclay
Copy link
Contributor Author

smclay commented Mar 9, 2022

@rtobar the travis CI fails for python 3.7 only. I do not know why

@rtobar rtobar merged commit 444574c into ICRAR:master Mar 16, 2022
@rtobar
Copy link
Contributor

rtobar commented Mar 16, 2022

The problem with 3.7 seems like a Travis environment issue that has been communicated to the setuptools people: pypa/setuptools#3118. I think we can safely ignore this for the time being, I'll pin the setuptools version later on the master branch to avoid this issue.

As for the code changes, they only touch ALMA-related code. If you're happy then I'm happy; in other words, I'll merge straight away.

@smclay smclay deleted the email-file-memory-fix branch April 4, 2022 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants