-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding CI jobs for gpu_nvidia devices #727
Conversation
Any idea why the CI checks aren't running? |
safety maybe, you are not part of the core devel ? |
I don't think it is that. I've had PRs with checks running before. The protection is supposed to only restrict checks running until you approved the first time. |
Don't merge until this runs, since I don't know if it will work correctly. |
The tests have passed, and I'm going to review the logs tomorrow to verify that the CUDA support is correctly being exercised. |
This looks good to me. Should we set PARSEC_MCA_device_cuda_enabled=1 for the Release tests? There is a comment in test.sh: if [ "$BUILD_TYPE" = "Release" ]; then
# enable devices only in tests that explicitely require them
PARSEC_MCA_device_cuda_enabled=0 |
We enable this selectively when we are testing CUDA enabled tests on the per-test properties so that should be alright. |
OK then you can merge if you are happy with it. |
@G-Ragghianti can you please sign your commits (using git -S, see https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits), this snippet may help |
c38078b
to
fbdbd7c
Compare
OK I have signed the commit. I will create another PR for gpu_amd support since it will likely be a bit more complicated than this one. |
No description provided.