Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding CI jobs for gpu_nvidia devices #727

Closed

Conversation

G-Ragghianti
Copy link
Contributor

No description provided.

@G-Ragghianti G-Ragghianti requested review from bosilca and a team as code owners February 4, 2025 09:53
@G-Ragghianti
Copy link
Contributor Author

Any idea why the CI checks aren't running?

@bosilca
Copy link
Contributor

bosilca commented Feb 4, 2025

safety maybe, you are not part of the core devel ?

@G-Ragghianti
Copy link
Contributor Author

I don't think it is that. I've had PRs with checks running before. The protection is supposed to only restrict checks running until you approved the first time.

@G-Ragghianti
Copy link
Contributor Author

Don't merge until this runs, since I don't know if it will work correctly.

@G-Ragghianti
Copy link
Contributor Author

The tests have passed, and I'm going to review the logs tomorrow to verify that the CUDA support is correctly being exercised.

@G-Ragghianti
Copy link
Contributor Author

This looks good to me. Should we set PARSEC_MCA_device_cuda_enabled=1 for the Release tests? There is a comment in test.sh:

if [ "$BUILD_TYPE" = "Release" ]; then
   # enable devices only in tests that explicitely require them
   PARSEC_MCA_device_cuda_enabled=0

@abouteiller
Copy link
Contributor

This looks good to me. Should we set PARSEC_MCA_device_cuda_enabled=1 for the Release tests? There is a comment in test.sh:

if [ "$BUILD_TYPE" = "Release" ]; then
   # enable devices only in tests that explicitely require them
   PARSEC_MCA_device_cuda_enabled=0

We enable this selectively when we are testing CUDA enabled tests on the per-test properties so that should be alright.

@G-Ragghianti
Copy link
Contributor Author

OK then you can merge if you are happy with it.

@abouteiller
Copy link
Contributor

@G-Ragghianti can you please sign your commits (using git -S, see https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits), this snippet may help git rebase --exec 'git commit --amend --no-edit -n -S' -i master

@G-Ragghianti
Copy link
Contributor Author

OK I have signed the commit. I will create another PR for gpu_amd support since it will likely be a bit more complicated than this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The CI configuration should request and use slurm tags to control what tests run and compile
3 participants