HAVE_PEER_ACCESS is always present in all relevant versions of CUDA or #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ROCM, so no need to cmake detect it. Signed-off-by: Aurelien Bouteiller <[email protected]>
bosilca
reviewed
Sep 6, 2023
| @@ -725,7 +717,7 @@ int main(int argc, char *argv[]) { | |||
| # This is kinda ugly but the PATH and HINTS don't get transmitted to sub-dependents | |||
| set(CMAKE_SYSTEM_PREFIX_PATH_save ${CMAKE_SYSTEM_PREFIX_PATH}) | |||
| list(APPEND CMAKE_SYSTEM_PREFIX_PATH /opt/rocm) | |||
There was a problem hiding this comment.
I don't think this explicit path should be here.
There was a problem hiding this comment.
Removing it would break the detection of the system install rocm (as installed from the RPMs distributed by AMD).
There was a problem hiding this comment.
Why cant you use PATHS or HINTS ? According to the cmake documentation that's the preferred way.
There was a problem hiding this comment.
Cmake 'feature/bug': unlike ROCM_ROOT, they do not get propagated to the internal find_packages that are done within FindRocm and that results in an inconsistent/incomplete detection of internal features, see comment just above line 717.
bosilca
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: ROCM would not use peer-access operators because we don't have a cmake test for the rocm-specific version of the have_peer_access function.
However, HAVE_PEER_ACCESS is always present in all relevant versions of CUDA or ROCM, so no need to cmake detect it, just require minimum cuda and rocm versions.