PEtab: Fix warning from fill_in_parameters with fixed parameters
#1509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dilpath
reviewed
Nov 18, 2024
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #1509 +/- ##
===========================================
+ Coverage 81.06% 81.08% +0.02%
===========================================
Files 163 163
Lines 13949 13955 +6
===========================================
+ Hits 11308 11316 +8
+ Misses 2641 2639 -2 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
FFroehlich
approved these changes
Nov 19, 2024
FFroehlich
approved these changes
Nov 19, 2024
dweindl
added a commit
to dweindl/pyPESTO
that referenced
this pull request
Nov 19, 2024
Follow-up to ICB-DCM#1493 and ICB-DCM#1509, which only filled in PEtab-fixed parameters for simulation but not preequilibration in the parameter mapping. Adding Weber_BMC2015 to the PEtab tests, where this issue popped up.
dweindl
added a commit
that referenced
this pull request
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a warning
RuntimeWarning: The following problem parameters were not used: {[...]} amici.petab.conditions.fill_in_parameters(in case of fixed parameters.The warning was issued since #1493.
This also fills in the fixed parameter values in the parameter mapping for the fixed parameters that was missing in #1493.