-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Select: problem-specific minimize method for SaCeSS #1339
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #1339 +/- ##
===========================================
+ Coverage 82.81% 82.82% +0.01%
===========================================
Files 163 163
Lines 13917 13950 +33
===========================================
+ Hits 11525 11554 +29
- Misses 2392 2396 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks useful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thank you!
@Doresic you can use PEtab-dev/petab_select#86 for nicer model hashes, when saving histories |
30a9118
to
927a28b
Compare
…o select_sacess_minimize_method
…o select_sacess_minimize_method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, lgtm.
Co-authored-by: Daniel Weindl <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works now, thanks.
Example use