Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select: problem-specific minimize method for SaCeSS #1339

Merged
merged 32 commits into from
Nov 12, 2024

Conversation

dilpath
Copy link
Member

@dilpath dilpath commented Mar 26, 2024

Example use

from pypesto.optimize.ess import SacessFidesFactory
from pypesto.select import SacessMinimizeMethod

minimize_options = {
    'startpoint_method': pypesto.startpoint.UniformStartpoints(),
}
minimize_method = SacessMinimizeMethod(
    num_workers=5,
    local_optimizer=SacessFidesFactory(fides_kwargs={
        'verbose': 0,
        'hessian_update': fides.BFGS()
    }),
    max_walltime_s=60,
    sacess_loglevel=logging.DEBUG,
    ess_loglevel=logging.WARNING,
)
model_problem_options = {
    'minimize_method': minimize_method,
    'minimize_options': minimize_options,
    'objective_customizer': objective_customizer,
}

best_models = pypesto_select_problem.select_to_completion(
    candidate_space=candidate_space,
    model_problem_options=model_problem_options,
)

@dilpath dilpath requested review from dweindl and Doresic March 26, 2024 13:05
@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 77.14286% with 8 lines in your changes missing coverage. Please review.

Project coverage is 82.82%. Comparing base (80a7b8d) to head (2de945e).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
pypesto/select/misc.py 74.19% 8 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1339      +/-   ##
===========================================
+ Coverage    82.81%   82.82%   +0.01%     
===========================================
  Files          163      163              
  Lines        13917    13950      +33     
===========================================
+ Hits         11525    11554      +29     
- Misses        2392     2396       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dweindl dweindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks useful.

Copy link
Contributor

@Doresic Doresic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@dilpath
Copy link
Member Author

dilpath commented Mar 26, 2024

@Doresic you can use PEtab-dev/petab_select#86 for nicer model hashes, when saving histories

@dilpath dilpath force-pushed the select_sacess_minimize_method branch from 30a9118 to 927a28b Compare March 27, 2024 10:34
@dilpath dilpath requested a review from dweindl November 12, 2024 10:27
Copy link
Member

@dweindl dweindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm.

Co-authored-by: Daniel Weindl <[email protected]>
Copy link
Contributor

@vwiela vwiela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works now, thanks.

Base automatically changed from select_use_old_calibrations to develop November 12, 2024 13:33
@dilpath dilpath added this pull request to the merge queue Nov 12, 2024
Merged via the queue into develop with commit e3b3c8a Nov 12, 2024
18 checks passed
@dilpath dilpath deleted the select_sacess_minimize_method branch November 12, 2024 17:55
This was referenced Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants