Fix data race in aggregateLikelihood #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a data race in case of multi-threaded simulations. nllh, objectiveFunctionGradient and simulationTimeSec are potentially updated by different threads at the same time.
|
Merged
dweindl
added a commit
that referenced
this pull request
Nov 28, 2024
## What's Changed ### Features * Updated AMICI to v0.29.0 which comes with many new features and bug fixes (by @dweindl in #412) * Added support for support for forward sensitivities (by @dweindl in #393) * Use amici default options in generated HDF5 input files (by @dweindl in #392, #406) * Set python package version via setuptools_scm (by @dweindl in #395) * PEtab import: option to ignore initialization prior (by @dweindl in #402) * Added scaffold for objective function / gradient evaluation with JSON I/O (by @dweindl in #400) ### Fixes * Fixed data race in aggregateLikelihood (by @dweindl in #411) * PEtab pipeline: * Fixed potentially incorrect initial state from condition table (by @dweindl in #408) * Fail on problems using priors (they aren't supported and never have been) (by @dweindl in #384) * Only compute sensitivities with respect to optimized parameters (by @dweindl in #394) * HDF5 generation: Don't write obsolete sens_ind (by @dweindl in #407) * Reduced clang warnings (by @dweindl in #397) **Full Changelog**: v0.4.10...v0.5.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a data race in case of multi-threaded simulations. nllh, objectiveFunctionGradient and simulationTimeSec are potentially updated by different threads at the same time.