Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEtab pipeline: Only compute sensitivities with respect to optimized parameters #380

Closed
dweindl opened this issue Dec 12, 2023 · 1 comment
Assignees
Labels

Comments

@dweindl
Copy link
Member

dweindl commented Dec 12, 2023

... currently this is done w.r.t. all parameters.

While less performance critical with ASA, it might still result in unnecessary simulation failures due to issues during gradient computation.

Related: #190, #343

@dweindl dweindl added the PEtab label Dec 12, 2023
@dweindl dweindl self-assigned this Oct 18, 2024
@dweindl
Copy link
Member Author

dweindl commented Oct 18, 2024

After #388, this will be less of an issue, since the more recent amici-petab-import will already treat petab-estimate=0 parameters as fixed parameters. What remains, is the handling of parameters w.r.t. which we only require sensitivity for certain simulation conditions. This then condition-specific amici-plist 1) needs to be written to the input files and 2) must be accounted for when aggregating the gradients from individual model simulations to the objective gradient.

dweindl added a commit that referenced this issue Oct 19, 2024
…parameters

* Make use of amici::ExpData::plist to compute only relevant sensitivities for each simulation condition.

* Update logging for nplist

* Include Bruno_JExpBot2016 on GHA, which is a great test case for plist

Closes #380
dweindl added a commit that referenced this issue Oct 19, 2024
…parameters

* Make use of amici::ExpData::plist to compute only relevant sensitivities for each simulation condition.

* Update logging for nplist

* Include Bruno_JExpBot2016 on GHA, which is a great test case for plist

Closes #380
dweindl added a commit that referenced this issue Oct 19, 2024
…parameters

* Make use of amici::ExpData::plist to compute only relevant sensitivities for each simulation condition.

* Update logging for nplist

* Include Bruno_JExpBot2016 on GHA, which is a great test case for plist

Closes #380
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant